cuberite/libevent
1
0
Fork 0
mirror of https://github.com/cuberite/libevent.git synced 2025-09-08 11:53:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix another nasty solaris getaddrinfo() behavior

Browse Source 
Everybody else thinks that when you getaddrinfo() on an ip address
and don't specify the protocol and the socktype, it should give you
multiple answers , one for each protocol/socktype implementation.

OpenSolaris takes a funny view of RFC3493, and leaves the results set
to 0.

This patch post-processes the getaddrinfo() results for consistency.
This commit is contained in:
Nick Mathewson 2010-05-08 19:16:47 -04:00
parent 2cf2a286e4
commit 3557071698
1 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
evutil.c
View File

@ -1055,6 +1055,26 @@ apply_numeric_port_hack(int port, struct evutil_addrinfo **ai)
}
}
}
static void
apply_socktype_protocol_hack(struct evutil_addrinfo *ai)
{
struct evutil_addrinfo *ai_new;
for (; ai; ai = ai->ai_next) {
evutil_getaddrinfo_infer_protocols(ai);
if (ai->ai_socktype || ai->ai_protocol)
continue;
ai_new = mm_malloc(sizeof(*ai_new));
memcpy(ai_new, ai, sizeof(*ai_new));
ai->ai_socktype = SOCK_STREAM;
ai->ai_protocol = IPPROTO_TCP;
ai_new->ai_socktype = SOCK_DGRAM;
ai_new->ai_protocol = IPPROTO_UDP;
ai_new->ai_next = ai->ai_next;
ai->ai_next = ai_new;
}
}
#endif
int
@ -1144,9 +1164,7 @@ evutil_getaddrinfo(const char *nodename, const char *servname,
apply_numeric_port_hack(portnum, res);
if (need_socktype_protocol_hack()) {
struct evutil_addrinfo *ai;
for (ai = *res; ai; ai = ai->ai_next)
evutil_getaddrinfo_infer_protocols(ai);
apply_socktype_protocol_hack(*res);
}
return err;
#else