cuberite/libevent
1
0
Fork 0
mirror of https://github.com/cuberite/libevent.git synced 2025-09-13 06:16:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make bufferevent_trigger_nolock_() inline

Browse Source 
Since most of its callers are using constant EV_READ or EV_WRITE, and
using constant 0 as its argument, this should eliminate most of the
overhead for this function in the fast case.
This commit is contained in:
Nick Mathewson 2013-12-24 11:20:52 -05:00
parent b4ef3def6f
commit 4dd3abd41f
2 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bufferevent-internal.h
View File

@ -354,8 +354,21 @@ void bufferevent_run_eventcb_(struct bufferevent *bufev, short what, int options
* BEV_TRIG_DEFER_CALLBACKS) I/O callbacks specified in iotype. * BEV_TRIG_DEFER_CALLBACKS) I/O callbacks specified in iotype.
* Must already hold the bufev lock. Honors watermarks unless * Must already hold the bufev lock. Honors watermarks unless
* BEV_TRIG_IGNORE_WATERMARKS is in options. */ * BEV_TRIG_IGNORE_WATERMARKS is in options. */
void bufferevent_trigger_nolock_(struct bufferevent *bufev, short iotype, int options); static inline void bufferevent_trigger_nolock_(struct bufferevent *bufev, short iotype, int options);
/* Making this inline since all of the common-case calls to this function in
* libevent use constant arguments. */
size_t evbuffer_get_length(const struct evbuffer *buf);
static inline void
bufferevent_trigger_nolock_(struct bufferevent *bufev, short iotype, int options)
{
if ((iotype & EV_READ) && ((options & BEV_TRIG_IGNORE_WATERMARKS) ||
evbuffer_get_length(bufev->input) >= bufev->wm_read.low))
bufferevent_run_readcb_(bufev, options);
if ((iotype & EV_WRITE) && ((options & BEV_TRIG_IGNORE_WATERMARKS) ||
evbuffer_get_length(bufev->output) <= bufev->wm_write.low))
bufferevent_run_writecb_(bufev, options);
}
/** Internal: Add the event 'ev' with timeout tv, unless tv is set to 0, in /** Internal: Add the event 'ev' with timeout tv, unless tv is set to 0, in
* which case add ev with no timeout. */ * which case add ev with no timeout. */

11
bufferevent.c
View File

@ -252,17 +252,6 @@ bufferevent_run_writecb_(struct bufferevent *bufev, int options)
} }
} }
void
bufferevent_trigger_nolock_(struct bufferevent *bufev, short iotype, int options)
{
if ((iotype & EV_READ) && ((options & BEV_TRIG_IGNORE_WATERMARKS) ||
evbuffer_get_length(bufev->input) >= bufev->wm_read.low))
bufferevent_run_readcb_(bufev, options);
if ((iotype & EV_WRITE) && ((options & BEV_TRIG_IGNORE_WATERMARKS) ||
evbuffer_get_length(bufev->output) <= bufev->wm_write.low))
bufferevent_run_writecb_(bufev, options);
}
void void
bufferevent_trigger(struct bufferevent *bufev, short iotype, int options) bufferevent_trigger(struct bufferevent *bufev, short iotype, int options)
{ {