cuberite/libevent
1
0
Fork 0
mirror of https://github.com/cuberite/libevent.git synced 2025-09-10 04:50:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove spurious checks in evrpc.c error cases (coverity)

Browse Source 
Coverity hates the case where you have a redundant NULL check after
using something.
This commit is contained in:
Nick Mathewson 2014-01-08 12:04:06 -05:00
parent 544cf8888a
commit 991b362001
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
evrpc.c
View File

@ -329,7 +329,6 @@ evrpc_request_cb(struct evhttp_request *req, void *arg)
return; return;
error: error:
if (rpc_state != NULL)
evrpc_reqstate_free_(rpc_state); evrpc_reqstate_free_(rpc_state);
evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL); evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL);
return; return;
@ -372,7 +371,6 @@ evrpc_request_cb_closure(void *arg, enum EVRPC_HOOK_RESULT hook_res)
return; return;
error: error:
if (rpc_state != NULL)
evrpc_reqstate_free_(rpc_state); evrpc_reqstate_free_(rpc_state);
evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL); evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL);
return; return;
@ -454,7 +452,6 @@ evrpc_request_done(struct evrpc_req_generic *rpc_state)
return; return;
error: error:
if (rpc_state != NULL)
evrpc_reqstate_free_(rpc_state); evrpc_reqstate_free_(rpc_state);
evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL); evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL);
return; return;