r16506@catbus: nickm | 2007-11-07 01:29:59 -0500

Make all rpc and http functions not prototyped in evrpc.h and evhttp.h into static functions.  I believe that these functions were meant to be private, yes?


svn:r494
This commit is contained in:
Nick Mathewson 2007-11-07 07:33:16 +00:00
parent 794857242f
commit a3f122d667
2 changed files with 12 additions and 12 deletions

View File

@ -190,7 +190,7 @@ void evrpc_request_done(struct evrpc_req_generic*);
* calls this function. * calls this function.
*/ */
char * static char *
evrpc_construct_uri(const char *uri) evrpc_construct_uri(const char *uri)
{ {
char *constructed_uri; char *constructed_uri;

22
http.c
View File

@ -226,7 +226,7 @@ evhttp_htmlescape(const char *html)
return (escaped_html); return (escaped_html);
} }
const char * static const char *
evhttp_method(enum evhttp_cmd_type type) evhttp_method(enum evhttp_cmd_type type)
{ {
const char *method; const char *method;
@ -597,12 +597,12 @@ evhttp_write(int fd, short what, void *arg)
(*evcon->cb)(evcon, evcon->cb_arg); (*evcon->cb)(evcon, evcon->cb_arg);
} }
void static void
evhttp_connection_done(struct evhttp_connection *evcon) evhttp_connection_done(struct evhttp_connection *evcon)
{ {
struct evhttp_request *req = TAILQ_FIRST(&evcon->requests); struct evhttp_request *req = TAILQ_FIRST(&evcon->requests);
int con_outgoing = evcon->flags & EVHTTP_CON_OUTGOING; int con_outgoing = evcon->flags & EVHTTP_CON_OUTGOING;
/* /*
* if this is an incoming connection, we need to leave the request * if this is an incoming connection, we need to leave the request
* on the connection, so that we can reply to it. * on the connection, so that we can reply to it.
@ -706,7 +706,7 @@ evhttp_handle_chunked_read(struct evhttp_request *req, struct evbuffer *buf)
return (0); return (0);
} }
void static void
evhttp_read_body(struct evhttp_connection *evcon, struct evhttp_request *req) evhttp_read_body(struct evhttp_connection *evcon, struct evhttp_request *req)
{ {
struct evbuffer *buf = evcon->input_buffer; struct evbuffer *buf = evcon->input_buffer;
@ -776,7 +776,7 @@ evhttp_read(int fd, short what, void *arg)
evhttp_read_body(evcon, req); evhttp_read_body(evcon, req);
} }
void static void
evhttp_write_connectioncb(struct evhttp_connection *evcon, void *arg) evhttp_write_connectioncb(struct evhttp_connection *evcon, void *arg)
{ {
/* This is after writing the request to the server */ /* This is after writing the request to the server */
@ -1000,7 +1000,7 @@ evhttp_connectioncb(int fd, short what, void *arg)
* Check if we got a valid response code. * Check if we got a valid response code.
*/ */
int static int
evhttp_valid_response_code(int code) evhttp_valid_response_code(int code)
{ {
if (code == 0) if (code == 0)
@ -1011,7 +1011,7 @@ evhttp_valid_response_code(int code)
/* Parses the status line of a web server */ /* Parses the status line of a web server */
int static int
evhttp_parse_response_line(struct evhttp_request *req, char *line) evhttp_parse_response_line(struct evhttp_request *req, char *line)
{ {
char *protocol; char *protocol;
@ -1053,7 +1053,7 @@ evhttp_parse_response_line(struct evhttp_request *req, char *line)
/* Parse the first line of a HTTP request */ /* Parse the first line of a HTTP request */
int static int
evhttp_parse_request_line(struct evhttp_request *req, char *line) evhttp_parse_request_line(struct evhttp_request *req, char *line)
{ {
char *method; char *method;
@ -1581,7 +1581,7 @@ evhttp_start_read(struct evhttp_connection *evcon)
evhttp_add_event(&evcon->ev, evcon->timeout, HTTP_READ_TIMEOUT); evhttp_add_event(&evcon->ev, evcon->timeout, HTTP_READ_TIMEOUT);
} }
void static void
evhttp_send_done(struct evhttp_connection *evcon, void *arg) evhttp_send_done(struct evhttp_connection *evcon, void *arg)
{ {
int need_close; int need_close;
@ -1893,7 +1893,7 @@ evhttp_dispatch_callback(struct httpcbq *callbacks, struct evhttp_request *req)
return (NULL); return (NULL);
} }
void static void
evhttp_handle_request(struct evhttp_request *req, void *arg) evhttp_handle_request(struct evhttp_request *req, void *arg)
{ {
struct evhttp *http = arg; struct evhttp *http = arg;
@ -1981,7 +1981,7 @@ evhttp_bind_socket(struct evhttp *http, const char *address, u_short port)
} }
static struct evhttp* static struct evhttp*
evhttp_new_object() evhttp_new_object(void)
{ {
struct evhttp *http = NULL; struct evhttp *http = NULL;