cuberite/libevent
1
0
Fork 0
mirror of https://github.com/cuberite/libevent.git synced 2025-09-09 12:28:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential fd leak in listener_read_cb()

Browse Source 
As pointed out by harlan_ in #libevent after running a coverity sweep.
If the listener is free'd, 'new_fd' is never closed.
This commit is contained in:
Mark Ellzey 2015-04-27 22:43:04 -04:00
parent 6e7a580c15
commit a695a720cd
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
listener.c
View File

@ -421,6 +421,8 @@ listener_read_cb(evutil_socket_t fd, short what, void *p)
if (lev->refcnt == 1) { if (lev->refcnt == 1) {
int freed = listener_decref_and_unlock(lev); int freed = listener_decref_and_unlock(lev);
EVUTIL_ASSERT(freed); EVUTIL_ASSERT(freed);
evutil_closesocket(new_fd);
return; return;
} }
--lev->refcnt; --lev->refcnt;