From a7a7a1904507bb7fcc22a3c045c030d2837c3510 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Mon, 26 Nov 2007 19:25:09 +0000 Subject: [PATCH] r16735@catbus: nickm | 2007-11-26 14:24:58 -0500 Fix test for EVBUFFER_LENGTH in evhttp_make_header(). Since appending an empty buffer to another is a no-op, this is not really a bug-fix. svn:r554 --- http.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/http.c b/http.c index 49d803ef..f0f1f6c8 100644 --- a/http.c +++ b/http.c @@ -441,9 +441,7 @@ evhttp_make_header(struct evhttp_connection *evcon, struct evhttp_request *req) } evbuffer_add(evcon->output_buffer, "\r\n", 2); - /* XXX EVBUFFER_LENGTH returns an unsigned value, so this test - * is always true. What is the intent of this test? -NM */ - if (1) { // || EVBUFFER_LENGTH(req->output_buffer) >= 0) { + if (EVBUFFER_LENGTH(req->output_buffer) > 0) { /* * For a request, we add the POST data, for a reply, this * is the regular data.