cuberite/libevent
1
0
Fork 0
mirror of https://github.com/cuberite/libevent.git synced 2025-09-10 04:50:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

dns-example: free result in getaddrinfo callback

Browse Source 
According to evdns.c, the result not freed by libevent after
the callback runs:

evdns_getaddrinfo_gotresolve()
{
    ...
    data->user_cb(0, data->pending_result, data->user_data);
    data->pending_result = NULL;
    ...
}

To reproduce, build with -fsanitize=address, add -g to the getopt
list in dns-example.c like in the current commit and run

  dns-example -g google.com

Closes: #681 # cherry-picked
(cherry picked from commit 855f0804305a545da6880850d16809969ce72edd)
This commit is contained in:
Bogdan Harjoc 2018-08-09 14:47:17 +03:00 committed by Azat Khuzhin
parent d6c293af00
commit d0cde45477
No known key found for this signature in database
GPG Key ID: B86086848EF8686D
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sample/dns-example.c
View File

@ -78,6 +78,8 @@ gai_callback(int err, struct evutil_addrinfo *ai, void *arg)
{ {
const char *name = arg; const char *name = arg;
int i; int i;
struct evutil_addrinfo *first_ai = ai;
if (err) { if (err) {
printf("%s: %s\n", name, evutil_gai_strerror(err)); printf("%s: %s\n", name, evutil_gai_strerror(err));
} }
@ -99,6 +101,9 @@ gai_callback(int err, struct evutil_addrinfo *ai, void *arg)
printf("[%d] %s: %s\n",i,name,buf); printf("[%d] %s: %s\n",i,name,buf);
} }
} }
if (first_ai)
evutil_freeaddrinfo(first_ai);
} }
static void static void
@ -166,7 +171,7 @@ main(int c, char **v) {
return 1; return 1;
} }
while ((opt = getopt(c, v, "xvc:Ts:")) != -1) { while ((opt = getopt(c, v, "xvc:Ts:g")) != -1) {
switch (opt) { switch (opt) {
case 'x': o.reverse = 1; break; case 'x': o.reverse = 1; break;
case 'v': ++verbose; break; case 'v': ++verbose; break;