From d19a3260875a85206752a2aa8eaabeefb7e854d7 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Wed, 8 Jun 2011 13:32:47 -0400 Subject: [PATCH] Remove a needless branch in evbuffer_drain() Found by Gilad Benjamini; see June 2011 thread "Dead or wrong code". --- buffer.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/buffer.c b/buffer.c index 98de504c..84d3aea8 100644 --- a/buffer.c +++ b/buffer.c @@ -934,10 +934,8 @@ evbuffer_drain(struct evbuffer *buf, size_t len) } buf->first = chain; - if (chain) { - chain->misalign += remaining; - chain->off -= remaining; - } + chain->misalign += remaining; + chain->off -= remaining; } buf->n_del_for_cb += len;