cuberite/libevent
1
0
Fork 0
mirror of https://github.com/cuberite/libevent.git synced 2025-09-12 13:58:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix lock leak in be_pair_flush() if flush type is BEV_NORMAL

Browse Source 
Fixes: bufferevent/bufferevent_pair_flush_normal
  $ regress --no-fork bufferevent/bufferevent_pair_flush_normal
  bufferevent/bufferevent_pair_flush_normal:
    FAIL ../test/regress_bufferevent.c:181: assert(bufferevent_pair_get_partner(bev1) == NULL): 0x177fa20 vs (nil)
    [bufferevent_pair_flush_normal FAILED]

Fixes #266
This commit is contained in:
Bill Vaughan 2015-07-24 05:40:59 -07:00 committed by Azat Khuzhin
parent ad52602ffd
commit f45d39d1a4
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bufferevent_pair.c
View File

@ -307,15 +307,17 @@ be_pair_flush(struct bufferevent *bev, short iotype,
{ {
struct bufferevent_pair *bev_p = upcast(bev); struct bufferevent_pair *bev_p = upcast(bev);
struct bufferevent *partner; struct bufferevent *partner;
incref_and_lock(bev);
if (!bev_p->partner) if (!bev_p->partner)
return -1; return -1;
partner = downcast(bev_p->partner);
if (mode == BEV_NORMAL) if (mode == BEV_NORMAL)
return 0; return 0;
incref_and_lock(bev);
partner = downcast(bev_p->partner);
if ((iotype & EV_READ) != 0) if ((iotype & EV_READ) != 0)
be_pair_transfer(partner, bev, 1); be_pair_transfer(partner, bev, 1);