cuberite/polarssl
1
0
Fork 0
mirror of https://github.com/cuberite/polarssl.git synced 2025-11-04 04:32:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove generic wildcard checks after review feedback

Browse Source 
Applied specific wildcard checks instead.

Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

# Conflicts:
#	library/psa_crypto.c
This commit is contained in:
Steven Cooreman 2021-02-18 12:07:20 +01:00
parent ee18b1f5a4
commit 0348802247
1 changed files with 103 additions and 105 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
library/psa_crypto.c
View File

@ -663,9 +663,6 @@ static psa_algorithm_t psa_key_policy_algorithm_intersection(
/* Common case: both sides actually specify the same policy. */ /* Common case: both sides actually specify the same policy. */
if( alg1 == alg2 ) if( alg1 == alg2 )
return( alg1 ); return( alg1 );
/* Special case: one or both sides contain a wildcard. */
if( PSA_ALG_IS_WILDCARD( alg1 ) || PSA_ALG_IS_WILDCARD( alg2 ) )
{
/* If the policies are from the same hash-and-sign family, check /* If the policies are from the same hash-and-sign family, check
* if one is a wildcard. If so the other has the specific algorithm. */ * if one is a wildcard. If so the other has the specific algorithm. */
if( PSA_ALG_IS_HASH_AND_SIGN( alg1 ) && if( PSA_ALG_IS_HASH_AND_SIGN( alg1 ) &&
@ -677,8 +674,8 @@ static psa_algorithm_t psa_key_policy_algorithm_intersection(
if( PSA_ALG_SIGN_GET_HASH( alg2 ) == PSA_ALG_ANY_HASH ) if( PSA_ALG_SIGN_GET_HASH( alg2 ) == PSA_ALG_ANY_HASH )
return( alg1 ); return( alg1 );
} }
/* If the policies are from the same AEAD family, then at least one /* If the policies are from the same AEAD family, check whether
* of them is a minimum-tag-length policy. Calculate the most * one f them is a minimum-tag-length wildcard. Calculate the most
* restrictive tag length. */ * restrictive tag length. */
if( PSA_ALG_IS_AEAD( alg1 ) && PSA_ALG_IS_AEAD( alg2 ) && if( PSA_ALG_IS_AEAD( alg1 ) && PSA_ALG_IS_AEAD( alg2 ) &&
( PSA_ALG_AEAD_WITH_SHORTENED_TAG( alg1, 0 ) == ( PSA_ALG_AEAD_WITH_SHORTENED_TAG( alg1, 0 ) ==
@ -689,22 +686,25 @@ static psa_algorithm_t psa_key_policy_algorithm_intersection(
size_t max_len = alg1_len > alg2_len ? alg1_len : alg2_len; size_t max_len = alg1_len > alg2_len ? alg1_len : alg2_len;
/* If both are wildcards, return most restricitve wildcard */ /* If both are wildcards, return most restricitve wildcard */
if( PSA_ALG_IS_WILDCARD( alg1 ) && PSA_ALG_IS_WILDCARD( alg2 ) ) if( ( ( alg1 & PSA_ALG_AEAD_MINIMUM_LENGTH_FLAG ) != 0 ) &&
( ( alg2 & PSA_ALG_AEAD_MINIMUM_LENGTH_FLAG ) != 0 ) )
{ {
return( PSA_ALG_AEAD_WITH_MINIMUM_LENGTH_TAG( alg1, max_len ) ); return( PSA_ALG_AEAD_WITH_MINIMUM_LENGTH_TAG( alg1, max_len ) );
} }
/* If only one is a wildcard, return specific algorithm if compatible. */ /* If only one is a wildcard, return specific algorithm if compatible. */
if( PSA_ALG_IS_WILDCARD( alg1 ) && (alg1_len <= alg2_len) ) if( ( ( alg1 & PSA_ALG_AEAD_MINIMUM_LENGTH_FLAG ) != 0 ) &&
( alg1_len <= alg2_len ) )
{ {
return( alg2 ); return( alg2 );
} }
if( PSA_ALG_IS_WILDCARD( alg2 ) && (alg2_len <= alg1_len) ) if( ( ( alg2 & PSA_ALG_AEAD_MINIMUM_LENGTH_FLAG ) != 0 ) &&
( alg2_len <= alg1_len ) )
{ {
return( alg1 ); return( alg1 );
} }
} }
/* If the policies are from the same MAC family, then at least one /* If the policies are from the same MAC family, check whether one
* of them is a minimum-tag-length policy. Calculate the most * of them is a minimum-MAC-length policy. Calculate the most
* restrictive tag length. */ * restrictive tag length. */
if( PSA_ALG_IS_MAC( alg1 ) && PSA_ALG_IS_MAC( alg2 ) && if( PSA_ALG_IS_MAC( alg1 ) && PSA_ALG_IS_MAC( alg2 ) &&
( PSA_ALG_FULL_LENGTH_MAC( alg1 ) == ( PSA_ALG_FULL_LENGTH_MAC( alg1 ) ==
@ -715,7 +715,8 @@ static psa_algorithm_t psa_key_policy_algorithm_intersection(
size_t max_len = alg1_len > alg2_len ? alg1_len : alg2_len; size_t max_len = alg1_len > alg2_len ? alg1_len : alg2_len;
/* If both are wildcards, return most restricitve wildcard */ /* If both are wildcards, return most restricitve wildcard */
if( PSA_ALG_IS_WILDCARD( alg1 ) && PSA_ALG_IS_WILDCARD( alg2 ) ) if( ( ( alg1 & PSA_ALG_MAC_MINIMUM_LENGTH_FLAG ) != 0 ) &&
( ( alg2 & PSA_ALG_MAC_MINIMUM_LENGTH_FLAG ) != 0 ) )
{ {
return( PSA_ALG_MAC_WITH_MINIMUM_LENGTH_TAG( alg1, max_len ) ); return( PSA_ALG_MAC_WITH_MINIMUM_LENGTH_TAG( alg1, max_len ) );
} }
@ -723,20 +724,19 @@ static psa_algorithm_t psa_key_policy_algorithm_intersection(
* Special case: specific MAC algorithm with '0' as length means full- * Special case: specific MAC algorithm with '0' as length means full-
* length MAC, which is always allowed by a wildcard with the same * length MAC, which is always allowed by a wildcard with the same
* base algorithm. */ * base algorithm. */
if( PSA_ALG_IS_WILDCARD( alg1 ) && if( ( ( alg1 & PSA_ALG_MAC_MINIMUM_LENGTH_FLAG ) != 0 ) &&
( ( alg1_len <= alg2_len ) || ( ( alg1_len <= alg2_len ) ||
( alg2 == PSA_ALG_FULL_LENGTH_MAC( alg1 ) ) ) ) ( alg2 == PSA_ALG_FULL_LENGTH_MAC( alg1 ) ) ) )
{ {
return( alg2 ); return( alg2 );
} }
if( PSA_ALG_IS_WILDCARD( alg2 ) && if( ( ( alg2 & PSA_ALG_MAC_MINIMUM_LENGTH_FLAG ) != 0 ) &&
( ( alg2_len <= alg1_len ) || ( ( alg2_len <= alg1_len ) ||
( alg1 == PSA_ALG_FULL_LENGTH_MAC( alg2 ) ) ) ) ( alg1 == PSA_ALG_FULL_LENGTH_MAC( alg2 ) ) ) )
{ {
return( alg1 ); return( alg1 );
} }
} }
}
/* If the policies are incompatible, allow nothing. */ /* If the policies are incompatible, allow nothing. */
return( 0 ); return( 0 );
} }
@ -750,9 +750,6 @@ static int psa_key_algorithm_permits( psa_algorithm_t policy_alg,
/* Common case: the policy only allows requested_alg. */ /* Common case: the policy only allows requested_alg. */
if( requested_alg == policy_alg ) if( requested_alg == policy_alg )
return( 1 ); return( 1 );
/* Special cases: the policy is an algorithm collection. */
if( PSA_ALG_IS_WILDCARD( policy_alg ) )
{
/* If policy_alg is a hash-and-sign with a wildcard for the hash, /* If policy_alg is a hash-and-sign with a wildcard for the hash,
* and requested_alg is the same hash-and-sign family with any hash, * and requested_alg is the same hash-and-sign family with any hash,
* then requested_alg is compliant with policy_alg. */ * then requested_alg is compliant with policy_alg. */
@ -768,7 +765,8 @@ static int psa_key_algorithm_permits( psa_algorithm_t policy_alg,
if( PSA_ALG_IS_AEAD( policy_alg ) && if( PSA_ALG_IS_AEAD( policy_alg ) &&
PSA_ALG_IS_AEAD( requested_alg ) && PSA_ALG_IS_AEAD( requested_alg ) &&
( PSA_ALG_AEAD_WITH_SHORTENED_TAG( policy_alg, 0 ) == ( PSA_ALG_AEAD_WITH_SHORTENED_TAG( policy_alg, 0 ) ==
PSA_ALG_AEAD_WITH_SHORTENED_TAG( requested_alg, 0 ) ) ) PSA_ALG_AEAD_WITH_SHORTENED_TAG( requested_alg, 0 ) ) &&
( ( policy_alg & PSA_ALG_AEAD_MINIMUM_LENGTH_FLAG ) != 0 ) )
{ {
return( PSA_ALG_AEAD_GET_TAG_LENGTH( policy_alg ) <= return( PSA_ALG_AEAD_GET_TAG_LENGTH( policy_alg ) <=
PSA_ALG_AEAD_GET_TAG_LENGTH( requested_alg ) ); PSA_ALG_AEAD_GET_TAG_LENGTH( requested_alg ) );
@ -779,7 +777,8 @@ static int psa_key_algorithm_permits( psa_algorithm_t policy_alg,
if( PSA_ALG_IS_MAC( policy_alg ) && if( PSA_ALG_IS_MAC( policy_alg ) &&
PSA_ALG_IS_MAC( requested_alg ) && PSA_ALG_IS_MAC( requested_alg ) &&
( PSA_ALG_FULL_LENGTH_MAC( policy_alg ) == ( PSA_ALG_FULL_LENGTH_MAC( policy_alg ) ==
PSA_ALG_FULL_LENGTH_MAC( requested_alg ) ) ) PSA_ALG_FULL_LENGTH_MAC( requested_alg ) ) &&
( ( policy_alg & PSA_ALG_MAC_MINIMUM_LENGTH_FLAG ) != 0 ) )
{ {
/* Special case: full-length MAC is encoded with 0-length. /* Special case: full-length MAC is encoded with 0-length.
* A minimum-length policy will always allow a full-length MAC. */ * A minimum-length policy will always allow a full-length MAC. */
@ -789,7 +788,6 @@ static int psa_key_algorithm_permits( psa_algorithm_t policy_alg,
return( PSA_MAC_TRUNCATED_LENGTH( policy_alg ) <= return( PSA_MAC_TRUNCATED_LENGTH( policy_alg ) <=
PSA_MAC_TRUNCATED_LENGTH( requested_alg ) ); PSA_MAC_TRUNCATED_LENGTH( requested_alg ) );
} }
}
/* If policy_alg is a generic key agreement operation, then using it for /* If policy_alg is a generic key agreement operation, then using it for
* a key derivation with that key agreement should also be allowed. This * a key derivation with that key agreement should also be allowed. This
* behaviour is expected to be defined in a future specification version. */ * behaviour is expected to be defined in a future specification version. */