cuberite/polarssl
1
0
Fork 0
mirror of https://github.com/cuberite/polarssl.git synced 2025-09-08 06:40:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential double-free in calloc selftest

Browse Source 
Where calloc returns two references to the same buffer, avoid calling
free() on both references by setting one to NULL.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
This commit is contained in:
David Horstmann 2023-12-07 14:14:21 +00:00
parent f09b837977
commit 05fde60d89
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
programs/test/selftest.c
View File

@ -83,6 +83,7 @@ static int calloc_self_test(int verbose)
if (verbose) { if (verbose) {
mbedtls_printf(" CALLOC(0,1): passed (same non-null)\n"); mbedtls_printf(" CALLOC(0,1): passed (same non-null)\n");
} }
empty2 = NULL;
} else { } else {
if (verbose) { if (verbose) {
mbedtls_printf(" CALLOC(0,1): passed (distinct non-null)\n"); mbedtls_printf(" CALLOC(0,1): passed (distinct non-null)\n");
@ -107,6 +108,7 @@ static int calloc_self_test(int verbose)
if (verbose) { if (verbose) {
mbedtls_printf(" CALLOC(1,0): passed (same non-null)\n"); mbedtls_printf(" CALLOC(1,0): passed (same non-null)\n");
} }
empty2 = NULL;
} else { } else {
if (verbose) { if (verbose) {
mbedtls_printf(" CALLOC(1,0): passed (distinct non-null)\n"); mbedtls_printf(" CALLOC(1,0): passed (distinct non-null)\n");
@ -123,6 +125,7 @@ static int calloc_self_test(int verbose)
mbedtls_printf(" CALLOC(1): failed (same buffer twice)\n"); mbedtls_printf(" CALLOC(1): failed (same buffer twice)\n");
} }
++failures; ++failures;
buffer2 = NULL;
} else { } else {
if (verbose) { if (verbose) {
mbedtls_printf(" CALLOC(1): passed\n"); mbedtls_printf(" CALLOC(1): passed\n");