cuberite/polarssl
1
0
Fork 0
mirror of https://github.com/cuberite/polarssl.git synced 2025-09-08 06:40:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

tests/test_suite_ecp: Fix ECP group compare test

Browse Source 
ECP group compare function should not check the value of T. We only need
to assert the value of T after the ECP group copy function is called.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>
This commit is contained in:
Gowtham Suresh Kumar 2023-07-10 22:50:29 +01:00
parent 76a54ff1a8
commit 21f2b7a64b
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/suites/test_suite_ecp.function
View File

@ -61,12 +61,11 @@ inline static int mbedtls_ecp_group_cmp(mbedtls_ecp_group *grp1,
if (grp1->t_data != grp2->t_data) {
return 1;
}
if (grp1->T_size != grp2->T_size) {
return 1;
}
if (grp1->T != grp2->T) {
return 1;
}
/* Here we should not compare T and T_size as the value of T is
* always NULL for Montgomery curves and for Weierstrass curves
* it will be NULL until ecp_mul is called. After calling ecp_mul,
* the value will be unique (dynamically allocated).
*/
return 0;
}
@ -1207,6 +1206,8 @@ void mbedtls_ecp_group_metadata(int id, int bit_size, int crv_type,
// Copy group and compare with original
TEST_EQUAL(mbedtls_ecp_group_copy(&grp_cpy, &grp), 0);
TEST_ASSERT(grp_cpy.T == NULL);
TEST_ASSERT(grp_cpy.T_size == 0);
TEST_EQUAL(mbedtls_ecp_group_cmp(&grp, &grp_cpy), 0);
// Check curve is in curve list and group ID list