cuberite/polarssl
1
0
Fork 0
mirror of https://github.com/cuberite/polarssl.git synced 2025-11-04 04:32:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

Error out if a test case uses an unknown macro name

Browse Source 
Insist that test cases must only use macro names that are declared in
a header. This may catch errors such as not parsing the intended
files.

Make this check easily overridden in a derived class.
This commit is contained in:
Gilles Peskine 2019-11-21 19:49:26 +01:00
parent 98a710c5b2
commit 2bcfc714d2
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tests/scripts/test_psa_constant_names.py
View File

@ -69,6 +69,7 @@ class Inputs:
""" """
def __init__(self): def __init__(self):
self.all_declared = set()
# Sets of names per type # Sets of names per type
self.statuses = set(['PSA_SUCCESS']) self.statuses = set(['PSA_SUCCESS'])
self.algorithms = set(['0xffffffff']) self.algorithms = set(['0xffffffff'])
@ -213,6 +214,7 @@ class Inputs:
if not m: if not m:
return return
name = m.group(1) name = m.group(1)
self.all_declared.add(name)
if re.search(self._excluded_name_re, name) or \ if re.search(self._excluded_name_re, name) or \
name in self._excluded_names: name in self._excluded_names:
return return
@ -229,6 +231,19 @@ class Inputs:
for line in lines: for line in lines:
self.parse_header_line(line) self.parse_header_line(line)
_macro_identifier_re = r'[A-Z]\w+'
def generate_undeclared_names(self, expr):
for name in re.findall(self._macro_identifier_re, expr):
if name not in self.all_declared:
yield name
def accept_test_case_line(self, function, argument):
#pylint: disable=unused-argument
undeclared = list(self.generate_undeclared_names(argument))
if undeclared:
raise Exception('Undeclared names in test case', undeclared)
return True
def add_test_case_line(self, function, argument): def add_test_case_line(self, function, argument):
"""Parse a test case data line, looking for algorithm metadata tests.""" """Parse a test case data line, looking for algorithm metadata tests."""
sets = [] sets = []
@ -240,8 +255,9 @@ class Inputs:
sets.append(self.algorithms) sets.append(self.algorithms)
if function in self.table_by_test_function: if function in self.table_by_test_function:
sets.append(self.table_by_test_function[function]) sets.append(self.table_by_test_function[function])
for s in sets: if self.accept_test_case_line(function, argument):
s.add(argument) for s in sets:
s.add(argument)
# Regex matching a *.data line containing a test function call and # Regex matching a *.data line containing a test function call and
# its arguments. The actual definition is partly positional, but this # its arguments. The actual definition is partly positional, but this