From 3bd17f2f582fdcfffc6254ac4f811cbd986e3fbb Mon Sep 17 00:00:00 2001 From: Nick Child Date: Tue, 31 Jan 2023 20:42:26 +0000 Subject: [PATCH] pkcs7: Use end_issuer_and_sn where appropriate There were some areas where `end_signer` were being used when it makes more sense to use `end_issuer_and_sn`, as pointed out by demiobenour@gmail.com. Signed-off-by: Nick Child --- library/pkcs7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/library/pkcs7.c b/library/pkcs7.c index 05d98c353..f380a7026 100644 --- a/library/pkcs7.c +++ b/library/pkcs7.c @@ -317,7 +317,7 @@ static int pkcs7_get_signer_info(unsigned char **p, unsigned char *end, /* Parsing IssuerAndSerialNumber */ signer->issuer_raw.p = *p; - asn1_ret = mbedtls_asn1_get_tag(p, end_signer, &len, + asn1_ret = mbedtls_asn1_get_tag(p, end_issuer_and_sn, &len, MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE); if (asn1_ret != 0) { goto out; @@ -330,7 +330,7 @@ static int pkcs7_get_signer_info(unsigned char **p, unsigned char *end, signer->issuer_raw.len = *p - signer->issuer_raw.p; - ret = mbedtls_x509_get_serial(p, end_signer, &signer->serial); + ret = mbedtls_x509_get_serial(p, end_issuer_and_sn, &signer->serial); if (ret != 0) { goto out; }