cuberite/polarssl
1
0
Fork 0
mirror of https://github.com/cuberite/polarssl.git synced 2025-10-30 19:20:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add check for return code of bignumber code

Browse Source 
Add check for return code of `mbedtls_mpi_write_file`
as commented by @sbutcher-arm
This commit is contained in:
Ron Eldor 2017-08-24 14:20:17 +03:00
parent 8266acacc8
commit 6a9257bc57
1 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
programs/pkey/key_app.c
View File

@ -105,7 +105,7 @@ int main( int argc, char *argv[] )
{ {
usage: usage:
mbedtls_printf( USAGE ); mbedtls_printf( USAGE );
goto exit; goto cleanup;
} }
opt.mode = DFL_MODE; opt.mode = DFL_MODE;
@ -155,13 +155,13 @@ int main( int argc, char *argv[] )
if( ( f = fopen( opt.password_file, "rb" ) ) == NULL ) if( ( f = fopen( opt.password_file, "rb" ) ) == NULL )
{ {
mbedtls_printf( " failed\n ! fopen returned NULL\n" ); mbedtls_printf( " failed\n ! fopen returned NULL\n" );
goto exit; goto cleanup;
} }
if( fgets( buf, sizeof(buf), f ) == NULL ) if( fgets( buf, sizeof(buf), f ) == NULL )
{ {
fclose( f ); fclose( f );
mbedtls_printf( "Error: fgets() failed to retrieve password\n" ); mbedtls_printf( "Error: fgets() failed to retrieve password\n" );
goto exit; goto cleanup;
} }
fclose( f ); fclose( f );
@ -182,7 +182,7 @@ int main( int argc, char *argv[] )
if( ret != 0 ) if( ret != 0 )
{ {
mbedtls_printf( " failed\n ! mbedtls_pk_parse_keyfile returned -0x%04x\n", -ret ); mbedtls_printf( " failed\n ! mbedtls_pk_parse_keyfile returned -0x%04x\n", -ret );
goto exit; goto cleanup;
} }
mbedtls_printf( " ok\n" ); mbedtls_printf( " ok\n" );
@ -203,14 +203,14 @@ int main( int argc, char *argv[] )
goto exit; goto exit;
} }
mbedtls_mpi_write_file( "N: ", &N, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "N: ", &rsa->N, 16, NULL ) );
mbedtls_mpi_write_file( "E: ", &E, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "E: ", &rsa->E, 16, NULL ) );
mbedtls_mpi_write_file( "D: ", &D, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "D: ", &rsa->D, 16, NULL ) );
mbedtls_mpi_write_file( "P: ", &P, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "P: ", &rsa->P, 16, NULL ) );
mbedtls_mpi_write_file( "Q: ", &Q, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "Q: ", &rsa->Q, 16, NULL ) );
mbedtls_mpi_write_file( "DP: ", &DP, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "DP: ", &rsa->DP, 16, NULL ) );
mbedtls_mpi_write_file( "DQ: ", &DQ, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "DQ: ", &rsa->DQ, 16, NULL ) );
mbedtls_mpi_write_file( "QP: ", &QP, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "QP: ", &rsa->QP, 16, NULL ) );
} }
else else
#endif #endif
@ -218,16 +218,16 @@ int main( int argc, char *argv[] )
if( mbedtls_pk_get_type( &pk ) == MBEDTLS_PK_ECKEY ) if( mbedtls_pk_get_type( &pk ) == MBEDTLS_PK_ECKEY )
{ {
mbedtls_ecp_keypair *ecp = mbedtls_pk_ec( pk ); mbedtls_ecp_keypair *ecp = mbedtls_pk_ec( pk );
mbedtls_mpi_write_file( "Q(X): ", &ecp->Q.X, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "Q(X): ", &ecp->Q.X, 16, NULL ) );
mbedtls_mpi_write_file( "Q(Y): ", &ecp->Q.Y, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "Q(Y): ", &ecp->Q.Y, 16, NULL ) );
mbedtls_mpi_write_file( "Q(Z): ", &ecp->Q.Z, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "Q(Z): ", &ecp->Q.Z, 16, NULL ) );
mbedtls_mpi_write_file( "D : ", &ecp->d , 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "D : ", &ecp->d , 16, NULL ) );
} }
else else
#endif #endif
{ {
mbedtls_printf("Do not know how to print key information for this type\n" ); mbedtls_printf("Do not know how to print key information for this type\n" );
goto exit; goto cleanup;
} }
} }
else if( opt.mode == MODE_PUBLIC ) else if( opt.mode == MODE_PUBLIC )
@ -243,7 +243,7 @@ int main( int argc, char *argv[] )
if( ret != 0 ) if( ret != 0 )
{ {
mbedtls_printf( " failed\n ! mbedtls_pk_parse_public_keyfile returned -0x%04x\n", -ret ); mbedtls_printf( " failed\n ! mbedtls_pk_parse_public_keyfile returned -0x%04x\n", -ret );
goto exit; goto cleanup;
} }
mbedtls_printf( " ok\n" ); mbedtls_printf( " ok\n" );
@ -260,8 +260,8 @@ int main( int argc, char *argv[] )
mbedtls_printf( " failed\n ! could not export RSA parameters\n\n" ); mbedtls_printf( " failed\n ! could not export RSA parameters\n\n" );
goto exit; goto exit;
} }
mbedtls_mpi_write_file( "N: ", &N, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "N: ", &rsa->N, 16, NULL ) );
mbedtls_mpi_write_file( "E: ", &E, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "E: ", &rsa->E, 16, NULL ) );
} }
else else
#endif #endif
@ -269,21 +269,21 @@ int main( int argc, char *argv[] )
if( mbedtls_pk_get_type( &pk ) == MBEDTLS_PK_ECKEY ) if( mbedtls_pk_get_type( &pk ) == MBEDTLS_PK_ECKEY )
{ {
mbedtls_ecp_keypair *ecp = mbedtls_pk_ec( pk ); mbedtls_ecp_keypair *ecp = mbedtls_pk_ec( pk );
mbedtls_mpi_write_file( "Q(X): ", &ecp->Q.X, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "Q(X): ", &ecp->Q.X, 16, NULL ) );
mbedtls_mpi_write_file( "Q(Y): ", &ecp->Q.Y, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "Q(Y): ", &ecp->Q.Y, 16, NULL ) );
mbedtls_mpi_write_file( "Q(Z): ", &ecp->Q.Z, 16, NULL ); MBEDTLS_MPI_CHK( mbedtls_mpi_write_file( "Q(Z): ", &ecp->Q.Z, 16, NULL ) );
} }
else else
#endif #endif
{ {
mbedtls_printf("Do not know how to print key information for this type\n" ); mbedtls_printf("Do not know how to print key information for this type\n" );
goto exit; goto cleanup;
} }
} }
else else
goto usage; goto usage;
exit: cleanup:
#if defined(MBEDTLS_ERROR_C) #if defined(MBEDTLS_ERROR_C)
if( ret != 0 ) if( ret != 0 )