cuberite/polarssl
1
0
Fork 0
mirror of https://github.com/cuberite/polarssl.git synced 2025-09-30 17:09:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix overly large allocations of MPIs

Browse Source 
The second argument of ASSERT_ALLOC is a number of array elements, not a
number of bytes.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
Gilles Peskine 2022-12-06 23:05:06 +01:00
parent de09ddd64e
commit 8781dd0e61
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/suites/test_suite_bignum_random.function
View File

@ -82,9 +82,9 @@ void mpi_core_random_basic( int min, char *bound_bytes, int expected_ret )
TEST_EQUAL( 0, mbedtls_test_read_mpi_core( &upper_bound, &limbs, TEST_EQUAL( 0, mbedtls_test_read_mpi_core( &upper_bound, &limbs,
bound_bytes ) ); bound_bytes ) );
ASSERT_ALLOC( lower_bound, limbs * ciL ); ASSERT_ALLOC( lower_bound, limbs );
lower_bound[0] = min; lower_bound[0] = min;
ASSERT_ALLOC( result, limbs * ciL ); ASSERT_ALLOC( result, limbs );
TEST_EQUAL( expected_ret, TEST_EQUAL( expected_ret,
mbedtls_mpi_core_random( result, min, upper_bound, limbs, mbedtls_mpi_core_random( result, min, upper_bound, limbs,
@ -121,7 +121,7 @@ void mpi_random_values( int min, char *max_hex )
TEST_EQUAL( 0, mbedtls_test_read_mpi( &max_legacy, max_hex ) ); TEST_EQUAL( 0, mbedtls_test_read_mpi( &max_legacy, max_hex ) );
size_t limbs = max_legacy.n; size_t limbs = max_legacy.n;
ASSERT_ALLOC( R_core, limbs * ciL ); ASSERT_ALLOC( R_core, limbs );
/* Call the legacy function and the core function with the same random /* Call the legacy function and the core function with the same random
* stream. */ * stream. */
@ -180,7 +180,7 @@ void mpi_random_many( int min, char *bound_hex, int iterations )
TEST_EQUAL( 0, mbedtls_test_read_mpi_core( &upper_bound, &limbs, TEST_EQUAL( 0, mbedtls_test_read_mpi_core( &upper_bound, &limbs,
bound_hex ) ); bound_hex ) );
ASSERT_ALLOC( result, limbs * ciL ); ASSERT_ALLOC( result, limbs );
n_bits = mbedtls_mpi_core_bitlen( upper_bound, limbs ); n_bits = mbedtls_mpi_core_bitlen( upper_bound, limbs );
/* Consider a bound "small" if it's less than 2^5. This value is chosen /* Consider a bound "small" if it's less than 2^5. This value is chosen