From afa7c04105813ded8972893144355a1999942acc Mon Sep 17 00:00:00 2001 From: Minos Galanakis Date: Wed, 21 Dec 2022 17:38:16 +0000 Subject: [PATCH] bignum_common.py: Refactored `BignumModRawConvertRep.generate_function_tests()` This patch adjusts the test generating method to calculate all possible combinations for (modulo, input, limb_sizes, representation). Signed-off-by: Minos Galanakis --- scripts/mbedtls_dev/bignum_mod_raw.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/scripts/mbedtls_dev/bignum_mod_raw.py b/scripts/mbedtls_dev/bignum_mod_raw.py index b244e0973..ebbc970e5 100644 --- a/scripts/mbedtls_dev/bignum_mod_raw.py +++ b/scripts/mbedtls_dev/bignum_mod_raw.py @@ -133,17 +133,13 @@ class BignumModRawConvertRep(bignum_common.ModOperationCommon, @classmethod def generate_function_tests(cls) -> Iterator[test_case.TestCase]: - representations = \ - bignum_common.ModulusRepresentation.supported_representations() - for rep in representations: - if rep is bignum_common.ModulusRepresentation.MONTGOMERY: - limb_sizes = cls.limb_sizes #type: Union[List[int], List[None]] - else: - limb_sizes = [None] # no dependency on limb size + + for rep in bignum_common.ModulusRepresentation.supported_representations(): for n in cls.moduli: for a in cls.input_values: - for bil in limb_sizes: - test_object = cls(n, a, bil, rep) + for bil in cls.limb_sizes: + test_object = cls(n, a, bits_in_limb=bil) + test_object.set_representation(rep) if test_object.is_valid: yield test_object.create_test_case()