From b000f82d7621ab6983c714c73b8ad800ff2c67c5 Mon Sep 17 00:00:00 2001 From: Paul Bakker Date: Mon, 17 Mar 2014 13:41:51 +0100 Subject: [PATCH] ssl_init() left a dirty in_ctr pointer on failed allocation of out_ctr --- ChangeLog | 2 ++ library/ssl_tls.c | 1 + 2 files changed, 3 insertions(+) diff --git a/ChangeLog b/ChangeLog index aef4d6a88..e7e2a7106 100644 --- a/ChangeLog +++ b/ChangeLog @@ -33,6 +33,8 @@ Bugfix * Fixed CMake symlinking on out-of-source builds * Bignum's MIPS-32 assembly was used on MIPS-64, causing chaos. (Found by Alex Wilson.) + * ssl_init() was leaving a dirty pointer in ssl_context if malloc of + out_ctr failed = Version 1.2.10 released 2013-10-07 Changes diff --git a/library/ssl_tls.c b/library/ssl_tls.c index c42ecccf6..4704b4416 100644 --- a/library/ssl_tls.c +++ b/library/ssl_tls.c @@ -3051,6 +3051,7 @@ int ssl_init( ssl_context *ssl ) { SSL_DEBUG_MSG( 1, ( "malloc(%d bytes) failed", len ) ); free( ssl-> in_ctr ); + ssl->in_ctr = NULL; return( POLARSSL_ERR_SSL_MALLOC_FAILED ); }