From f38adbe5588b90764de0e3882fc7eb6359a5cd1a Mon Sep 17 00:00:00 2001 From: Paul Elliott Date: Wed, 15 Sep 2021 17:04:19 +0100 Subject: [PATCH] Ensure tests expected to fail actually fail Signed-off-by: Paul Elliott --- tests/suites/test_suite_psa_crypto.function | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/suites/test_suite_psa_crypto.function b/tests/suites/test_suite_psa_crypto.function index 7c3e9904d..f9f013a22 100644 --- a/tests/suites/test_suite_psa_crypto.function +++ b/tests/suites/test_suite_psa_crypto.function @@ -524,16 +524,18 @@ static int aead_multipart_internal_func( int key_type_arg, data_t *key_data, ( input_data->x + data_true_size ), tag_length ); - if( status != PSA_SUCCESS ) + if( expect_valid_signature ) + PSA_ASSERT( status ); + else { - if( !expect_valid_signature ) + TEST_ASSERT( status != PSA_SUCCESS ); + + if( status != PSA_SUCCESS ) { /* Expected failure. */ test_ok = 1; goto exit; } - else - PSA_ASSERT( status ); } }