cuberite/polarssl
1
0
Fork 0
mirror of https://github.com/cuberite/polarssl.git synced 2025-11-04 04:32:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

Improve the description of common macros usage

Browse Source 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
This commit is contained in:
Ronald Cron 2021-09-27 13:59:38 +02:00
parent 99733f0511
commit fecda8ddb4
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
docs/architecture/tls13-experimental.md
View File

@ -262,17 +262,24 @@ TLS 1.3 specific coding rules:
unsigned char *cipher_suites; unsigned char *cipher_suites;
``` ```
- Use of MBEDTLS_BYTE_xyz, MBEDTLS_PUT/GET_xyz, MBEDTLS_SSL_CHK_BUF_PTR - Where applicable, use:
MBEDTLS_SSL_CHK_BUF_READ_PTR macros where applicable. - the macros to extract a byte from a multi-byte integer MBEDTLS_BYTE_{0-8}.
- the macros to write in memory in big-endian order a multi-byte integer
MBEDTLS_PUT_UINT{8|16|32|64}_BE.
- the macros to read from memory a multi-byte integer in big-endian order
MBEDTLS_GET_UINT{8|16|32|64}_BE.
- the macro to check for space when writing into an output buffer
`MBEDTLS_SSL_CHK_BUF_PTR`.
- the macro to check for data when reading from an input buffer
`MBEDTLS_SSL_CHK_BUF_READ_PTR`.
These macros were introduced after the prototype was written thus are These macros were introduced after the prototype was written thus are
likely not to be used in prototype where we now would use them in likely not to be used in prototype where we now would use them in
development. development.
The two first types, MBEDTLS_BYTE_xyz and MBEDTLS_PUT/GET_xyz, improve The three first types, MBEDTLS_BYTE_{0-8}, MBEDTLS_PUT_UINT{8|16|32|64}_BE
the readability of the code and reduce the risk of writing or reading and MBEDTLS_GET_UINT{8|16|32|64}_BE improve the readability of the code and
bytes in the wrong order: we should probably have only MBEDTLS_GET/PUT_*_BE reduce the risk of writing or reading bytes in the wrong order.
(BE stands for Big-Endian) macros in the TLS 1.3 code.
The two last types, `MBEDTLS_SSL_CHK_BUF_PTR` and The two last types, `MBEDTLS_SSL_CHK_BUF_PTR` and
`MBEDTLS_SSL_CHK_BUF_READ_PTR`, improve the readability of the code and `MBEDTLS_SSL_CHK_BUF_READ_PTR`, improve the readability of the code and