From 1806febcf4f90adea471bf4ebd5edc6fc92315e3 Mon Sep 17 00:00:00 2001 From: Matthieu Gautier Date: Wed, 21 Jun 2023 11:38:47 +0200 Subject: [PATCH] Fix iterator `next`. `next` must return the "next" value. But here, the next value is the value of the current iterator. --- lib/src/main/cpp/libzim/search_iterator.cpp | 2 +- lib/src/main/cpp/libzim/suggestion_iterator.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/src/main/cpp/libzim/search_iterator.cpp b/lib/src/main/cpp/libzim/search_iterator.cpp index 6c04c7d..65e1342 100644 --- a/lib/src/main/cpp/libzim/search_iterator.cpp +++ b/lib/src/main/cpp/libzim/search_iterator.cpp @@ -64,8 +64,8 @@ METHOD0(jboolean, hasNext) { } METHOD0(jobject, next) { - (*THIS)++; zim::Entry entry = **THIS; + (*THIS)++; return BUILD_WRAPPER("org/kiwix/libzim/Entry", entry); } diff --git a/lib/src/main/cpp/libzim/suggestion_iterator.cpp b/lib/src/main/cpp/libzim/suggestion_iterator.cpp index 5181ae1..2d2c410 100644 --- a/lib/src/main/cpp/libzim/suggestion_iterator.cpp +++ b/lib/src/main/cpp/libzim/suggestion_iterator.cpp @@ -49,8 +49,8 @@ METHOD0(jboolean, hasNext) { } METHOD0(jobject, next) { - (*THIS)++; zim::SuggestionItem item = **THIS; + (*THIS)++; return BUILD_WRAPPER("org/kiwix/libzim/SuggestionItem", item); }