From 0435d73f64b17daea48779db90e421c8c5a7be86 Mon Sep 17 00:00:00 2001 From: Sean Mac Gillicuddy Date: Thu, 11 Jun 2020 10:53:45 +0100 Subject: [PATCH] #2110 Zoom controls disappeared in v3.3.1 - add summary for storage pref to have reliabe clickable element --- .../kiwixmobile/settings/KiwixSettingsActivityTest.java | 5 +---- core/src/main/res/values/strings.xml | 1 + core/src/main/res/xml/preferences.xml | 1 + 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/app/src/androidTest/java/org/kiwix/kiwixmobile/settings/KiwixSettingsActivityTest.java b/app/src/androidTest/java/org/kiwix/kiwixmobile/settings/KiwixSettingsActivityTest.java index b5b4d15ad..3223aec8b 100644 --- a/app/src/androidTest/java/org/kiwix/kiwixmobile/settings/KiwixSettingsActivityTest.java +++ b/app/src/androidTest/java/org/kiwix/kiwixmobile/settings/KiwixSettingsActivityTest.java @@ -60,12 +60,9 @@ public class KiwixSettingsActivityTest { assertDisplayed(R.string.pref_language_title); } - /* - * This will fail locally but needs these values to pass on CI emulators - * */ @Test public void testStorageDialog() { - clickOn(R.string.external_storage); + clickOn(R.string.pref_storage_summary); assertDisplayed(R.string.internal_storage); } diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml index a9d025c69..0e5002912 100644 --- a/core/src/main/res/values/strings.xml +++ b/core/src/main/res/values/strings.xml @@ -275,6 +275,7 @@ Please send all the following details so we can diagnose the problem %d%% Text Zoom + Choose where files get saved to @string/on @string/off diff --git a/core/src/main/res/xml/preferences.xml b/core/src/main/res/xml/preferences.xml index df5a70319..b4c7825ce 100644 --- a/core/src/main/res/xml/preferences.xml +++ b/core/src/main/res/xml/preferences.xml @@ -69,6 +69,7 @@