From 1499919247ef9786a8b61721309fe846f8d4905d Mon Sep 17 00:00:00 2001 From: mhutti1 Date: Sun, 8 Jul 2018 12:36:48 +0100 Subject: [PATCH] Fix crash when attempting to bookmark help --- .../org/kiwix/kiwixmobile/KiwixMobileActivity.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/KiwixMobileActivity.java b/app/src/main/java/org/kiwix/kiwixmobile/KiwixMobileActivity.java index af8e9c7f2..4c41def69 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/KiwixMobileActivity.java +++ b/app/src/main/java/org/kiwix/kiwixmobile/KiwixMobileActivity.java @@ -191,6 +191,8 @@ public class KiwixMobileActivity extends BaseActivity implements WebViewCallback private ArrayList bookmarks; + private boolean bookmarkTabEnabled; + private List mWebViews = new ArrayList<>(); private KiwixTextToSpeech tts; @@ -340,7 +342,9 @@ public class KiwixMobileActivity extends BaseActivity implements WebViewCallback @Override public void onBookmarkTabSelected() { - toggleBookmark(); + if (bookmarkTabEnabled) { + toggleBookmark(); + } } @Override @@ -1627,13 +1631,15 @@ public class KiwixMobileActivity extends BaseActivity implements WebViewCallback .getIcon().setAlpha(255); bookmarkTab.getCustomView().findViewById(R.id.bookmark_tab_icon).setBackgroundResource(icon); + bookmarkTabEnabled = true; } else { menu.findItem(R.id.menu_bookmarks) - .setEnabled(false) - .setIcon(R.drawable.action_bookmark) - .getIcon().setAlpha(130); + .setEnabled(false) + .setIcon(R.drawable.action_bookmark) + .getIcon().setAlpha(130); bookmarkTab.getCustomView().findViewById(R.id.bookmark_tab_icon).setBackgroundResource(R.drawable.action_bookmark); + bookmarkTabEnabled = false; } }