From 21583e76c02d0c06bbd4d2fe6190210df68bd59c Mon Sep 17 00:00:00 2001 From: MohitMaliFtechiz Date: Fri, 16 May 2025 15:43:45 +0530 Subject: [PATCH] Fixed: The `testBookmarks` failing on Android 13 and above. --- .../org/kiwix/kiwixmobile/language/LanguageFragmentTest.kt | 5 ++++- .../kiwixmobile/page/bookmarks/LibkiwixBookmarkTest.kt | 6 +++--- .../kiwix/kiwixmobile/page/history/NavigationHistoryTest.kt | 4 +++- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/app/src/androidTest/java/org/kiwix/kiwixmobile/language/LanguageFragmentTest.kt b/app/src/androidTest/java/org/kiwix/kiwixmobile/language/LanguageFragmentTest.kt index 241ee4850..1039c2887 100644 --- a/app/src/androidTest/java/org/kiwix/kiwixmobile/language/LanguageFragmentTest.kt +++ b/app/src/androidTest/java/org/kiwix/kiwixmobile/language/LanguageFragmentTest.kt @@ -19,6 +19,7 @@ package org.kiwix.kiwixmobile.language import android.Manifest import android.app.Instrumentation +import android.os.Build import androidx.compose.ui.test.junit4.createComposeRule import androidx.core.content.edit import androidx.lifecycle.Lifecycle @@ -207,6 +208,8 @@ class LanguageFragmentTest { ) clickOnSaveLanguageIcon(composeTestRule) } - LeakAssertions.assertNoLeaks() + if (Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU) { + LeakAssertions.assertNoLeaks() + } } } diff --git a/app/src/androidTest/java/org/kiwix/kiwixmobile/page/bookmarks/LibkiwixBookmarkTest.kt b/app/src/androidTest/java/org/kiwix/kiwixmobile/page/bookmarks/LibkiwixBookmarkTest.kt index 2e93dc968..86b789315 100644 --- a/app/src/androidTest/java/org/kiwix/kiwixmobile/page/bookmarks/LibkiwixBookmarkTest.kt +++ b/app/src/androidTest/java/org/kiwix/kiwixmobile/page/bookmarks/LibkiwixBookmarkTest.kt @@ -134,9 +134,9 @@ class LibkiwixBookmarkTest : BaseActivityTest() { pressBack() // Test saving bookmark clickOnSaveBookmarkImage() - topLevel { - clickBookmarksOnNavDrawer { assertBookmarkSaved(composeTestRule) } - } + openBookmarkScreen() + assertBookmarkSaved(composeTestRule) + pressBack() // Test removing bookmark clickOnSaveBookmarkImage() longClickOnSaveBookmarkImage() diff --git a/app/src/androidTest/java/org/kiwix/kiwixmobile/page/history/NavigationHistoryTest.kt b/app/src/androidTest/java/org/kiwix/kiwixmobile/page/history/NavigationHistoryTest.kt index 307fcc819..da96ca91b 100644 --- a/app/src/androidTest/java/org/kiwix/kiwixmobile/page/history/NavigationHistoryTest.kt +++ b/app/src/androidTest/java/org/kiwix/kiwixmobile/page/history/NavigationHistoryTest.kt @@ -161,7 +161,9 @@ class NavigationHistoryTest : BaseActivityTest() { pressBack() pressBack() } - if (Build.VERSION.SDK_INT > Build.VERSION_CODES.N_MR1) { + if (Build.VERSION.SDK_INT > Build.VERSION_CODES.N_MR1 && + Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU + ) { // temporary disabled on Android 25 LeakAssertions.assertNoLeaks() }