kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-18 11:55:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

#2338 fixed actionBar and webViewList leaks.

Browse Source
This commit is contained in:
HissPirat 2020-08-26 14:34:29 +02:00
parent bbb630b9ca
commit 22a29b8ed8
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreReaderFragment.java
View File

@ -112,13 +112,13 @@ import org.kiwix.kiwixmobile.core.reader.ZimFileReader;
import org.kiwix.kiwixmobile.core.reader.ZimReaderContainer; import org.kiwix.kiwixmobile.core.reader.ZimReaderContainer;
import org.kiwix.kiwixmobile.core.search.SearchActivity; import org.kiwix.kiwixmobile.core.search.SearchActivity;
import org.kiwix.kiwixmobile.core.search.viewmodel.effects.SearchInPreviousScreen; import org.kiwix.kiwixmobile.core.search.viewmodel.effects.SearchInPreviousScreen;
import org.kiwix.kiwixmobile.core.utils.dialog.DialogShower;
import org.kiwix.kiwixmobile.core.utils.ExternalLinkOpener; import org.kiwix.kiwixmobile.core.utils.ExternalLinkOpener;
import org.kiwix.kiwixmobile.core.utils.dialog.KiwixDialog;
import org.kiwix.kiwixmobile.core.utils.LanguageUtils; import org.kiwix.kiwixmobile.core.utils.LanguageUtils;
import org.kiwix.kiwixmobile.core.utils.SharedPreferenceUtil; import org.kiwix.kiwixmobile.core.utils.SharedPreferenceUtil;
import org.kiwix.kiwixmobile.core.utils.StyleUtils; import org.kiwix.kiwixmobile.core.utils.StyleUtils;
import org.kiwix.kiwixmobile.core.utils.UpdateUtils; import org.kiwix.kiwixmobile.core.utils.UpdateUtils;
import org.kiwix.kiwixmobile.core.utils.dialog.DialogShower;
import org.kiwix.kiwixmobile.core.utils.dialog.KiwixDialog;
import org.kiwix.kiwixmobile.core.utils.files.FileUtils; import org.kiwix.kiwixmobile.core.utils.files.FileUtils;
import static android.app.Activity.RESULT_CANCELED; import static android.app.Activity.RESULT_CANCELED;
@ -728,6 +728,8 @@ public abstract class CoreReaderFragment extends BaseFragment
tabCallback = null; tabCallback = null;
hideBackToTopTimer.cancel(); hideBackToTopTimer.cancel();
hideBackToTopTimer = null; hideBackToTopTimer = null;
webViewList.clear();
actionBar = null;
tableDrawerAdapter.setTableClickListener(null); tableDrawerAdapter.setTableClickListener(null);
tableDrawerAdapter = null; tableDrawerAdapter = null;
unbinder.unbind(); unbinder.unbind();
@ -1655,7 +1657,8 @@ public abstract class CoreReaderFragment extends BaseFragment
} }
} }
selectTab(currentTab); selectTab(currentTab);
webViewList.get(currentTab).loadUrl(UpdateUtils.reformatProviderUrl(urls.getString(currentTab))); webViewList.get(currentTab)
.loadUrl(UpdateUtils.reformatProviderUrl(urls.getString(currentTab)));
getCurrentWebView().setScrollY(positions.getInt(currentTab)); getCurrentWebView().setScrollY(positions.getInt(currentTab));
} catch (JSONException e) { } catch (JSONException e) {
Log.w(TAG_KIWIX, "Kiwix shared preferences corrupted", e); Log.w(TAG_KIWIX, "Kiwix shared preferences corrupted", e);