From 25a077c6581bb992e70b54cc33c76339d0572978 Mon Sep 17 00:00:00 2001 From: Sean Mac Gillicuddy Date: Thu, 28 Nov 2019 15:28:32 +0000 Subject: [PATCH] #1301 reuse AppBar and Toolbar to avoid duplication --- .../kiwixmobile/language/LanguageActivity.kt | 3 +- .../LocalFileTransferActivity.java | 2 +- .../zim_manager/ZimManageActivity.kt | 3 +- app/src/main/res/layout/activity_language.xml | 16 +-- .../layout/activity_local_file_transfer.xml | 122 +++++++----------- app/src/main/res/layout/zim_manager.xml | 9 +- .../kiwixmobile/core/help/HelpActivity.java | 2 +- .../kiwixmobile/core/main/AddNoteDialog.java | 2 +- .../core/main/CoreMainActivity.java | 2 +- .../main/res/layout/activity_bookmarks.xml | 16 +-- core/src/main/res/layout/activity_help.xml | 16 +-- core/src/main/res/layout/activity_history.xml | 16 +-- .../src/main/res/layout/activity_zim_host.xml | 16 +-- core/src/main/res/layout/dialog_add_note.xml | 17 +-- .../res/layout/layout_standard_app_bar.xml | 13 ++ core/src/main/res/layout/layout_toolbar.xml | 13 ++ .../main/res/layout/main_activity_content.xml | 11 +- core/src/main/res/layout/search.xml | 7 +- core/src/main/res/layout/settings.xml | 14 +- 19 files changed, 98 insertions(+), 202 deletions(-) create mode 100644 core/src/main/res/layout/layout_standard_app_bar.xml create mode 100644 core/src/main/res/layout/layout_toolbar.xml diff --git a/app/src/main/java/org/kiwix/kiwixmobile/language/LanguageActivity.kt b/app/src/main/java/org/kiwix/kiwixmobile/language/LanguageActivity.kt index 8af76d078..40ab8ab47 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/language/LanguageActivity.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/language/LanguageActivity.kt @@ -29,7 +29,6 @@ import androidx.recyclerview.widget.RecyclerView import io.reactivex.disposables.CompositeDisposable import kotlinx.android.synthetic.main.activity_language.language_progressbar import kotlinx.android.synthetic.main.activity_language.language_recycler_view -import kotlinx.android.synthetic.main.activity_language.toolbar import org.kiwix.kiwixmobile.R import org.kiwix.kiwixmobile.core.base.BaseActivity import org.kiwix.kiwixmobile.core.extensions.ActivityExtensions.viewModel @@ -69,7 +68,7 @@ class LanguageActivity : BaseActivity() { override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) setContentView(R.layout.activity_language) - setSupportActionBar(toolbar) + setSupportActionBar(findViewById(R.id.toolbar)) supportActionBar?.let { it.setDisplayHomeAsUpEnabled(true) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/local_file_transfer/LocalFileTransferActivity.java b/app/src/main/java/org/kiwix/kiwixmobile/local_file_transfer/LocalFileTransferActivity.java index b5190d239..95edd3e9e 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/local_file_transfer/LocalFileTransferActivity.java +++ b/app/src/main/java/org/kiwix/kiwixmobile/local_file_transfer/LocalFileTransferActivity.java @@ -85,7 +85,7 @@ public class LocalFileTransferActivity extends BaseActivity implements @Inject WifiDirectManager wifiDirectManager; @Inject LocationManager locationManager; - @BindView(R.id.toolbar_local_file_transfer) Toolbar actionBar; + @BindView(R.id.toolbar) Toolbar actionBar; @BindView(R.id.text_view_device_name) TextView deviceName; @BindView(R.id.progress_bar_searching_peers) ProgressBar searchingPeersProgressBar; @BindView(R.id.list_peer_devices) ListView listViewPeerDevices; diff --git a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/ZimManageActivity.kt b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/ZimManageActivity.kt index 73e14aacd..bfcc6fd77 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/ZimManageActivity.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/ZimManageActivity.kt @@ -23,10 +23,10 @@ import android.provider.Settings.System import android.view.Menu import android.view.MenuItem import androidx.appcompat.widget.SearchView +import androidx.appcompat.widget.Toolbar import androidx.lifecycle.ViewModelProvider import kotlinx.android.synthetic.main.zim_manager.manageViewPager import kotlinx.android.synthetic.main.zim_manager.tabs -import kotlinx.android.synthetic.main.zim_manager.toolbar import org.kiwix.kiwixmobile.R import org.kiwix.kiwixmobile.core.base.BaseActivity import org.kiwix.kiwixmobile.core.dao.NewLanguagesDao @@ -93,6 +93,7 @@ class ZimManageActivity : BaseActivity() { } private fun setUpToolbar() { + val toolbar = findViewById(R.id.toolbar) setSupportActionBar(toolbar) supportActionBar!!.setHomeButtonEnabled(true) supportActionBar!!.setDisplayHomeAsUpEnabled(true) diff --git a/app/src/main/res/layout/activity_language.xml b/app/src/main/res/layout/activity_language.xml index 8e59f7184..5773161cd 100644 --- a/app/src/main/res/layout/activity_language.xml +++ b/app/src/main/res/layout/activity_language.xml @@ -5,17 +5,7 @@ android:layout_height="match_parent" android:fitsSystemWindows="true"> - - - - + + app:layout_constraintTop_toBottomOf="@id/app_bar" /> + app:layout_constraintTop_toBottomOf="@id/app_bar" /> diff --git a/app/src/main/res/layout/activity_local_file_transfer.xml b/app/src/main/res/layout/activity_local_file_transfer.xml index 0d30d14e8..e37b45bdf 100644 --- a/app/src/main/res/layout/activity_local_file_transfer.xml +++ b/app/src/main/res/layout/activity_local_file_transfer.xml @@ -4,36 +4,19 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" - android:fitsSystemWindows="true" android:background="@android:color/transparent" - tools:context="org.kiwix.kiwixmobile.local_file_transfer.LocalFileTransferActivity" - > + android:fitsSystemWindows="true" + tools:context="org.kiwix.kiwixmobile.local_file_transfer.LocalFileTransferActivity"> - - - - - + + app:layout_constraintTop_toBottomOf="@+id/app_bar" /> + android:textIsSelectable="true" + android:textSize="17sp" + android:textStyle="bold" + app:layout_constraintHorizontal_bias="0.0" + app:layout_constraintLeft_toLeftOf="parent" + app:layout_constraintRight_toRightOf="parent" + app:layout_constraintTop_toBottomOf="@id/text_view_your_device" + tools:hint="Device Name" /> + android:background="@color/accent" + app:layout_constraintLeft_toLeftOf="parent" + app:layout_constraintRight_toRightOf="parent" + app:layout_constraintTop_toBottomOf="@id/text_view_device_name" /> + app:layout_constraintTop_toBottomOf="@id/view_device_list_boundary" /> + app:layout_constraintTop_toBottomOf="@id/text_view_available_device" + app:layout_constraintVertical_bias="0.0" /> + app:layout_constraintTop_toBottomOf="@id/text_view_available_device" /> + app:layout_constraintTop_toBottomOf="@id/text_view_available_device" /> + app:layout_constraintTop_toBottomOf="@id/text_view_available_device" /> + app:layout_constraintTop_toBottomOf="@id/view_file_list_boundary" /> + app:layout_constraintTop_toBottomOf="@id/text_view_files_for_transfer" /> diff --git a/app/src/main/res/layout/zim_manager.xml b/app/src/main/res/layout/zim_manager.xml index 0c1e39daa..4982af223 100644 --- a/app/src/main/res/layout/zim_manager.xml +++ b/app/src/main/res/layout/zim_manager.xml @@ -8,17 +8,10 @@ tools:context="org.kiwix.kiwixmobile.zim_manager.ZimManageActivity"> - + titleDescriptionMap = new HashMap<>(); - @BindView(R2.id.activity_help_toolbar) + @BindView(R2.id.toolbar) Toolbar toolbar; @BindView(R2.id.activity_help_recycler_view) RecyclerView recyclerView; diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/main/AddNoteDialog.java b/core/src/main/java/org/kiwix/kiwixmobile/core/main/AddNoteDialog.java index 954665ab0..9ac4f5c4d 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/main/AddNoteDialog.java +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/main/AddNoteDialog.java @@ -75,7 +75,7 @@ public class AddNoteDialog extends DialogFragment Environment.getExternalStorageDirectory() + "/Kiwix/Notes/"; public static final String TAG = "AddNoteDialog"; - @BindView(R2.id.add_note_toolbar) + @BindView(R2.id.toolbar) Toolbar toolbar; // Displays options for the note dialog @BindView(R2.id.add_note_text_view) TextView addNoteTextView; // Displays article title diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreMainActivity.java b/core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreMainActivity.java index 0330907e1..cbe9b1172 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreMainActivity.java +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreMainActivity.java @@ -161,7 +161,7 @@ public abstract class CoreMainActivity extends BaseActivity implements WebViewCa protected final List webViewList = new ArrayList<>(); @BindView(R2.id.activity_main_root) ConstraintLayout root; - @BindView(R2.id.activity_main_toolbar) + @BindView(R2.id.toolbar) Toolbar toolbar; @BindView(R2.id.activity_main_back_to_top_fab) FloatingActionButton backToTopButton; diff --git a/core/src/main/res/layout/activity_bookmarks.xml b/core/src/main/res/layout/activity_bookmarks.xml index 8479331fa..20d7de44c 100644 --- a/core/src/main/res/layout/activity_bookmarks.xml +++ b/core/src/main/res/layout/activity_bookmarks.xml @@ -5,19 +5,7 @@ android:layout_height="match_parent" android:fitsSystemWindows="true"> - - - - + + app:layout_constraintTop_toBottomOf="@id/app_bar" /> diff --git a/core/src/main/res/layout/activity_help.xml b/core/src/main/res/layout/activity_help.xml index 5d1c727c3..db73ab55b 100644 --- a/core/src/main/res/layout/activity_help.xml +++ b/core/src/main/res/layout/activity_help.xml @@ -7,19 +7,7 @@ android:fitsSystemWindows="true" tools:context=".help.HelpActivity"> - - - - + - - - - + + app:layout_constraintTop_toBottomOf="@id/app_bar" /> diff --git a/core/src/main/res/layout/activity_zim_host.xml b/core/src/main/res/layout/activity_zim_host.xml index 81dd2770a..d266981a3 100644 --- a/core/src/main/res/layout/activity_zim_host.xml +++ b/core/src/main/res/layout/activity_zim_host.xml @@ -7,19 +7,7 @@ android:fitsSystemWindows="true" tools:context=".webserver.ZimHostActivity"> - - - - + + app:layout_constraintTop_toBottomOf="@+id/app_bar" /> - - - - - + + app:layout_constraintTop_toBottomOf="@+id/app_bar"> + + + + + diff --git a/core/src/main/res/layout/layout_toolbar.xml b/core/src/main/res/layout/layout_toolbar.xml new file mode 100644 index 000000000..edafdcf04 --- /dev/null +++ b/core/src/main/res/layout/layout_toolbar.xml @@ -0,0 +1,13 @@ + + + + + diff --git a/core/src/main/res/layout/main_activity_content.xml b/core/src/main/res/layout/main_activity_content.xml index bd6d68b15..5950fee10 100644 --- a/core/src/main/res/layout/main_activity_content.xml +++ b/core/src/main/res/layout/main_activity_content.xml @@ -17,14 +17,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content"> - + diff --git a/core/src/main/res/layout/search.xml b/core/src/main/res/layout/search.xml index 2b4913f3c..4f69ed379 100644 --- a/core/src/main/res/layout/search.xml +++ b/core/src/main/res/layout/search.xml @@ -15,12 +15,7 @@ android:layout_width="match_parent" android:layout_height="?android:attr/actionBarSize"> - + @@ -10,18 +9,7 @@ android:layout_height="match_parent" android:orientation="vertical"> - - - - +