From 88dba92b4a1240b2e3ff00876805401dfa5b13e4 Mon Sep 17 00:00:00 2001 From: Yash Khare Date: Tue, 7 Apr 2020 22:43:56 +0530 Subject: [PATCH 1/6] Fix #1946 Make a single dialog with a list view of all zims to be deleted --- app/lint-baseline.xml | 4 +-- .../fileselect_view/effects/DeleteFiles.kt | 25 ++++++++++++++----- .../kiwixmobile/core/utils/KiwixDialog.kt | 5 ++-- core/src/main/res/values-ar/strings.xml | 2 +- core/src/main/res/values-ast/strings.xml | 2 +- core/src/main/res/values-bg/strings.xml | 2 +- core/src/main/res/values-bn/strings.xml | 2 +- core/src/main/res/values-br/strings.xml | 2 +- core/src/main/res/values-ca/strings.xml | 2 +- core/src/main/res/values-ckb/strings.xml | 2 +- core/src/main/res/values-cs/strings.xml | 2 +- core/src/main/res/values-da/strings.xml | 2 +- core/src/main/res/values-de/strings.xml | 2 +- core/src/main/res/values-diq/strings.xml | 2 +- core/src/main/res/values-el/strings.xml | 2 +- core/src/main/res/values-eo/strings.xml | 2 +- core/src/main/res/values-es/strings.xml | 2 +- core/src/main/res/values-eu/strings.xml | 2 +- core/src/main/res/values-fa/strings.xml | 2 +- core/src/main/res/values-fi/strings.xml | 2 +- core/src/main/res/values-fr/strings.xml | 2 +- core/src/main/res/values-gl/strings.xml | 2 +- core/src/main/res/values-hi/strings.xml | 2 +- core/src/main/res/values-hu/strings.xml | 2 +- core/src/main/res/values-in/strings.xml | 2 +- core/src/main/res/values-it/strings.xml | 2 +- core/src/main/res/values-iw/strings.xml | 2 +- core/src/main/res/values-ji/strings.xml | 2 +- core/src/main/res/values-ko/strings.xml | 2 +- core/src/main/res/values-ku/strings.xml | 2 +- core/src/main/res/values-lb/strings.xml | 2 +- core/src/main/res/values-li/strings.xml | 2 +- core/src/main/res/values-lv/strings.xml | 2 +- core/src/main/res/values-mk/strings.xml | 2 +- core/src/main/res/values-my/strings.xml | 2 +- core/src/main/res/values-ne/strings.xml | 2 +- core/src/main/res/values-oc/strings.xml | 2 +- core/src/main/res/values-pl/strings.xml | 2 +- core/src/main/res/values-pt-rBR/strings.xml | 2 +- core/src/main/res/values-pt/strings.xml | 2 +- core/src/main/res/values-ro/strings.xml | 2 +- core/src/main/res/values-ru/strings.xml | 2 +- core/src/main/res/values-sc/strings.xml | 2 +- core/src/main/res/values-sl/strings.xml | 2 +- core/src/main/res/values-sq/strings.xml | 2 +- core/src/main/res/values-sr/strings.xml | 2 +- core/src/main/res/values-su/strings.xml | 2 +- core/src/main/res/values-sv/strings.xml | 2 +- core/src/main/res/values-th/strings.xml | 2 +- core/src/main/res/values-tr/strings.xml | 2 +- core/src/main/res/values-uk/strings.xml | 2 +- core/src/main/res/values-vi/strings.xml | 2 +- core/src/main/res/values-xmf/strings.xml | 2 +- core/src/main/res/values-zh-rTW/strings.xml | 2 +- core/src/main/res/values-zh/strings.xml | 2 +- core/src/main/res/values/strings.xml | 6 ++--- 56 files changed, 78 insertions(+), 66 deletions(-) diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml index 995d85b07..f29f19c83 100644 --- a/app/lint-baseline.xml +++ b/app/lint-baseline.xml @@ -1311,8 +1311,8 @@ ) : override fun invokeWith(activity: AppCompatActivity) { (activity as ZimManageActivity).cachedComponent.inject(this) + + var name = "\n" booksOnDiskListItem.forEach { - dialogShower.show(DeleteZim(it), { + name += "\n" + it.book.title + } + + dialogShower.show(DeleteZims(name), { + var allDeleted = true + + booksOnDiskListItem.forEach { if (deleteSpecificZimFile(it)) { if (it.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { zimReaderContainer.setZimFile(null) } - activity.toast(R.string.delete_specific_zim_toast) } else { - activity.toast(R.string.delete_zim_failed) + allDeleted = false } - }) - } + } + + if (allDeleted) { + activity.toast(R.string.delete_zims_toast) + } else { + activity.toast(R.string.delete_zim_failed) + } + }) } private fun deleteSpecificZimFile(book: BookOnDisk): Boolean { diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/utils/KiwixDialog.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/utils/KiwixDialog.kt index 258ac9d4c..a18d0677b 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/utils/KiwixDialog.kt +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/utils/KiwixDialog.kt @@ -21,7 +21,6 @@ package org.kiwix.kiwixmobile.core.utils import android.net.wifi.WifiConfiguration import android.view.View import org.kiwix.kiwixmobile.core.R -import org.kiwix.kiwixmobile.core.zim_manager.fileselect_view.adapter.BooksOnDiskListItem.BookOnDisk sealed class KiwixDialog( val title: Int?, @@ -34,10 +33,10 @@ sealed class KiwixDialog( val getView: (() -> View)? = null ) { - data class DeleteZim(override val args: List) : KiwixDialog( + data class DeleteZims(override val args: List) : KiwixDialog( null, R.string.delete_zim_body, R.string.delete, R.string.no ), HasBodyFormatArgs { - constructor(bookOnDisk: BookOnDisk) : this(listOf(bookOnDisk.book.title)) + constructor(zimNameList: String) : this(listOf(zimNameList)) } object LocationPermissionRationale : KiwixDialog( diff --git a/core/src/main/res/values-ar/strings.xml b/core/src/main/res/values-ar/strings.xml index 51254ed4b..a2550cd1b 100644 --- a/core/src/main/res/values-ar/strings.xml +++ b/core/src/main/res/values-ar/strings.xml @@ -111,7 +111,7 @@ متصل المكتبة حذف %s؟ - حُذف الملف + حُذف الملف لا توجد ملفات هنا لا توجد مساحة كافية لتنزيل هذا الملف. المساحة المتاحة: diff --git a/core/src/main/res/values-ast/strings.xml b/core/src/main/res/values-ast/strings.xml index 2ab55ab7d..188b72879 100644 --- a/core/src/main/res/values-ast/strings.xml +++ b/core/src/main/res/values-ast/strings.xml @@ -107,7 +107,7 @@ En llinia Biblioteca ¿Desaniciar %s? - Ficheru desaniciáu + Ficheru desaniciáu Nun hai nengún ficheru equí Nun hai espaciu abondo pa descargar esti ficheru. Espaciu disponible: diff --git a/core/src/main/res/values-bg/strings.xml b/core/src/main/res/values-bg/strings.xml index 5ff1cfd13..aa9ebb907 100644 --- a/core/src/main/res/values-bg/strings.xml +++ b/core/src/main/res/values-bg/strings.xml @@ -82,7 +82,7 @@ Устройство Онлайн Библиотека - Файлът е изтрит + Файлът е изтрит Тук няма файлове Няма достатъчно място за даунлоуд на този файл. Налично пространство: diff --git a/core/src/main/res/values-bn/strings.xml b/core/src/main/res/values-bn/strings.xml index 3b5a3de65..40a424b8c 100644 --- a/core/src/main/res/values-bn/strings.xml +++ b/core/src/main/res/values-bn/strings.xml @@ -80,7 +80,7 @@ ডিভাইস অনলাইন পাঠাগার - ফাইল অপসারণ করা হয়েছে + ফাইল অপসারণ করা হয়েছে এখানে কোন ফাইল নেই এই ফাইল ডাউনলোড করার মত যথেষ্ট স্থান নেই উপলব্ধ খালিস্থান: diff --git a/core/src/main/res/values-br/strings.xml b/core/src/main/res/values-br/strings.xml index 98cd170f3..58c77b0db 100644 --- a/core/src/main/res/values-br/strings.xml +++ b/core/src/main/res/values-br/strings.xml @@ -80,7 +80,7 @@ Trobarzhell Enlinenn Levraoueg - Restr dilamet + Restr dilamet N\'eus restr ebet amañ N\'eus ket plas a-walc\'h evit pellgargañ ar restr-mañ. Egorenn a c\'haller kaout : diff --git a/core/src/main/res/values-ca/strings.xml b/core/src/main/res/values-ca/strings.xml index 903629076..ab0986035 100644 --- a/core/src/main/res/values-ca/strings.xml +++ b/core/src/main/res/values-ca/strings.xml @@ -63,7 +63,7 @@ Dispositiu Biblioteca Voleu suprimir %s? - Fitxer esborrat + Fitxer esborrat Cap fitxer aquí Espai insuficient per descarregar aquest fitxer. Cap connexió de xarxa diff --git a/core/src/main/res/values-ckb/strings.xml b/core/src/main/res/values-ckb/strings.xml index a3e8d1f1d..5f3bb1b0c 100644 --- a/core/src/main/res/values-ckb/strings.xml +++ b/core/src/main/res/values-ckb/strings.xml @@ -79,7 +79,7 @@ سەرھێڵ کتێبخانە لابردنی %s - پەڕگە سڕدرایەوە + پەڕگە سڕدرایەوە ھیچ پەڕگەیەک لێرە نییە بۆشایی بەردەستە: سادە diff --git a/core/src/main/res/values-cs/strings.xml b/core/src/main/res/values-cs/strings.xml index 71ce7a4df..3b91d77a5 100644 --- a/core/src/main/res/values-cs/strings.xml +++ b/core/src/main/res/values-cs/strings.xml @@ -107,7 +107,7 @@ Online Knihovna Vymazat %s? - Soubor byl smazán + Soubor byl smazán Zde nejsou žádné soubory Nedostatečný prostor ke stažení tohoto souboru. Dostupné místo: diff --git a/core/src/main/res/values-da/strings.xml b/core/src/main/res/values-da/strings.xml index 47ba194a4..ba386a47f 100644 --- a/core/src/main/res/values-da/strings.xml +++ b/core/src/main/res/values-da/strings.xml @@ -85,7 +85,7 @@ Enhed På nettet Bibliotek - Fil slettet + Fil slettet Ingen filer her Utilstrækkelig med plads til at hente denne fil. Ledig plads: diff --git a/core/src/main/res/values-de/strings.xml b/core/src/main/res/values-de/strings.xml index 3947f72e8..d6f87f513 100644 --- a/core/src/main/res/values-de/strings.xml +++ b/core/src/main/res/values-de/strings.xml @@ -78,7 +78,7 @@ Gerät Online Bibliothek - Datei gelöscht + Datei gelöscht Hier gibt es keine Dateien Nicht ausreichender Speicher, um diese Datei herunterzuladen. Verfügbarer Speicher: diff --git a/core/src/main/res/values-diq/strings.xml b/core/src/main/res/values-diq/strings.xml index 1dd233f82..502339003 100644 --- a/core/src/main/res/values-diq/strings.xml +++ b/core/src/main/res/values-diq/strings.xml @@ -88,7 +88,7 @@ Online Kıtıbxane Wa %s esteriyo ? - Dosya esteriye + Dosya esteriye Tiya dosyeyi çıniyê Seba barkerdışê na dosya rê ca bes niyo. Karnıyayiye erd: diff --git a/core/src/main/res/values-el/strings.xml b/core/src/main/res/values-el/strings.xml index f29c23922..16732aad4 100644 --- a/core/src/main/res/values-el/strings.xml +++ b/core/src/main/res/values-el/strings.xml @@ -72,7 +72,7 @@ Συσκευή Συνδεδεμένος Βιβλιοθήκη - Το αρχείο διαγράφηκε + Το αρχείο διαγράφηκε Δεν υπάρχουν αρχεία εδώ Μη επαρκής αποθηκευτικός χώρος για την λήψη του αρχείου. Διαθέσιμος αποθηκευτικός χώρος: diff --git a/core/src/main/res/values-eo/strings.xml b/core/src/main/res/values-eo/strings.xml index ef92cad94..f1b5bc1ff 100644 --- a/core/src/main/res/values-eo/strings.xml +++ b/core/src/main/res/values-eo/strings.xml @@ -84,7 +84,7 @@ Aparato Konektita Biblioteko - Forigis dosieron + Forigis dosieron Neniu dosiero ĉi tie Ne estas sufiĉa spaco por elŝuti ĉi tiun dosieron. Havebla Spaco: diff --git a/core/src/main/res/values-es/strings.xml b/core/src/main/res/values-es/strings.xml index 11f61dcc0..ddf948d9e 100644 --- a/core/src/main/res/values-es/strings.xml +++ b/core/src/main/res/values-es/strings.xml @@ -93,7 +93,7 @@ Dispositivo En línea Biblioteca - Archivo eliminado + Archivo eliminado Ningún archivo aquí Espacio insuficiente para descargar este archivo. Espacio disponible: diff --git a/core/src/main/res/values-eu/strings.xml b/core/src/main/res/values-eu/strings.xml index 2769823a9..a96fed5de 100644 --- a/core/src/main/res/values-eu/strings.xml +++ b/core/src/main/res/values-eu/strings.xml @@ -80,7 +80,7 @@ Gailua Konektatuta Liburutegia - Fitxategi ezabatua + Fitxategi ezabatua Artxiborik ez hemen Ez dago espaziorik artxibo hau jaisteko. Libre dagoen espazioa: diff --git a/core/src/main/res/values-fa/strings.xml b/core/src/main/res/values-fa/strings.xml index 0209d2434..ed66778ba 100644 --- a/core/src/main/res/values-fa/strings.xml +++ b/core/src/main/res/values-fa/strings.xml @@ -67,7 +67,7 @@ دستگاه برخط کتابخانه - پرونده حذف شد + پرونده حذف شد هیچ پرونده‌ای در این‌جا نیست فضای ناکافی برای بارگیری پرونده فضای موجود: diff --git a/core/src/main/res/values-fi/strings.xml b/core/src/main/res/values-fi/strings.xml index 1f6639aae..f00b32aad 100644 --- a/core/src/main/res/values-fi/strings.xml +++ b/core/src/main/res/values-fi/strings.xml @@ -91,7 +91,7 @@ Online Kirjasto Poista %s? - Tiedosto poistettu + Tiedosto poistettu Ei tiedostoja täällä Tilaa käytettävissä: Yksinkertainen diff --git a/core/src/main/res/values-fr/strings.xml b/core/src/main/res/values-fr/strings.xml index 26185ee3a..f0413d6d4 100644 --- a/core/src/main/res/values-fr/strings.xml +++ b/core/src/main/res/values-fr/strings.xml @@ -118,7 +118,7 @@ En ligne Bibliothèque Supprimer %s ? - Fichier supprimé + Fichier supprimé Aucun fichier ici Espace insuffisant pour télécharger ce fichier. Espace disponible : diff --git a/core/src/main/res/values-gl/strings.xml b/core/src/main/res/values-gl/strings.xml index d3e5ec954..40b7e1b01 100644 --- a/core/src/main/res/values-gl/strings.xml +++ b/core/src/main/res/values-gl/strings.xml @@ -78,7 +78,7 @@ Dispositivo En liña Biblioteca - Ficheiro eliminado + Ficheiro eliminado Ningún ficheiro aquí Espacio insuficiente para descargar este ficheiro. Espazo dispoñible: diff --git a/core/src/main/res/values-hi/strings.xml b/core/src/main/res/values-hi/strings.xml index 4dff33a48..e43e72c00 100644 --- a/core/src/main/res/values-hi/strings.xml +++ b/core/src/main/res/values-hi/strings.xml @@ -83,7 +83,7 @@ डिवाइस ऑनलाइन पुस्तकालय - फाइल हटा दी गई + फाइल हटा दी गई यहां कोई फ़ाइल नहीं इस फ़ाइल को डाउनलोड करने के लिए अपर्याप्त जगह। उपलब्ध जगह: diff --git a/core/src/main/res/values-hu/strings.xml b/core/src/main/res/values-hu/strings.xml index 6e0afc5bd..de2c6ae5a 100644 --- a/core/src/main/res/values-hu/strings.xml +++ b/core/src/main/res/values-hu/strings.xml @@ -84,7 +84,7 @@ Eszköz Elérhető Könyvtár - Fájl törölve + Fájl törölve Nincsenek fájlok Elégtelen mennyiségü tárhely a fájl letöltéséhez. Szabad tárhely: diff --git a/core/src/main/res/values-in/strings.xml b/core/src/main/res/values-in/strings.xml index 1b7ef4f93..a6d8dcfe4 100644 --- a/core/src/main/res/values-in/strings.xml +++ b/core/src/main/res/values-in/strings.xml @@ -80,7 +80,7 @@ Perangkat Daring Perpustakaan - Berkas telah dihapus + Berkas telah dihapus Tidak ada berkas disini Ruang tidak mencukupi untuk mengunduh berkas ini. Ruang yang Tersedia: diff --git a/core/src/main/res/values-it/strings.xml b/core/src/main/res/values-it/strings.xml index 22fc373b5..f540b17e4 100644 --- a/core/src/main/res/values-it/strings.xml +++ b/core/src/main/res/values-it/strings.xml @@ -68,7 +68,7 @@ Quando si apre una nuova scheda verrà aperta in background Dispositivo Libreria - File cancellato + File cancellato Nessun file qui Lo spazio è insufficiente per scaricare questo file. Spazio disponibile: diff --git a/core/src/main/res/values-iw/strings.xml b/core/src/main/res/values-iw/strings.xml index 97149bc68..626574a81 100644 --- a/core/src/main/res/values-iw/strings.xml +++ b/core/src/main/res/values-iw/strings.xml @@ -110,7 +110,7 @@ מקוון ספרייה למחוק את %s? - הקובץ נמחק + הקובץ נמחק אין כאן קבצים אין מספיק מקום כדי להוריד את הקובץ הזה. נפח זמין: diff --git a/core/src/main/res/values-ji/strings.xml b/core/src/main/res/values-ji/strings.xml index faaa92fe1..368e8b953 100644 --- a/core/src/main/res/values-ji/strings.xml +++ b/core/src/main/res/values-ji/strings.xml @@ -30,7 +30,7 @@ צי האט איר געוואוסט? אַנולירן ביבליאטעק - טעקע אויסגעמעקט + טעקע אויסגעמעקט קיין טעקעס דא יא diff --git a/core/src/main/res/values-ko/strings.xml b/core/src/main/res/values-ko/strings.xml index 6f8c57496..6dd9067e6 100644 --- a/core/src/main/res/values-ko/strings.xml +++ b/core/src/main/res/values-ko/strings.xml @@ -111,7 +111,7 @@ 온라인 라이브러리 %s을(를) 삭제하시겠습니까? - 파일이 삭제되었습니다 + 파일이 삭제되었습니다 여기에 파일이 없습니다 이 파일을 다운로드할 공간이 충분하지 않습니다. 사용 가능한 공간: diff --git a/core/src/main/res/values-ku/strings.xml b/core/src/main/res/values-ku/strings.xml index 2412f94e7..87f168fbd 100644 --- a/core/src/main/res/values-ku/strings.xml +++ b/core/src/main/res/values-ku/strings.xml @@ -78,7 +78,7 @@ Amûr Online Pirtûkxane - Pel hat jêbirin + Pel hat jêbirin Li vir peldank tune ne Ji bo daxistina vê peldankê cihê ku hewce dike, tune ye. Cihê berdestː diff --git a/core/src/main/res/values-lb/strings.xml b/core/src/main/res/values-lb/strings.xml index f32b9fe04..7d1f8ffb0 100644 --- a/core/src/main/res/values-lb/strings.xml +++ b/core/src/main/res/values-lb/strings.xml @@ -60,7 +60,7 @@ Online Bibliothéik %s läschen? - Fichier geläscht + Fichier geläscht Keng Fichieren hei? Net genuch Plaz fir dëse Fichier erofzelueden. Plaz disponibel: diff --git a/core/src/main/res/values-li/strings.xml b/core/src/main/res/values-li/strings.xml index 0f385126d..19c7e3c1b 100644 --- a/core/src/main/res/values-li/strings.xml +++ b/core/src/main/res/values-li/strings.xml @@ -61,7 +61,7 @@ Toustèl Online Haol inhawd op - Bestandj eweggesjaf + Bestandj eweggesjaf Gein bestenj hie Neet zat ruumdje veur dit bestandj te downloade. Gein netwerkverbinjing diff --git a/core/src/main/res/values-lv/strings.xml b/core/src/main/res/values-lv/strings.xml index 517c05833..d8b9f4a2a 100644 --- a/core/src/main/res/values-lv/strings.xml +++ b/core/src/main/res/values-lv/strings.xml @@ -24,7 +24,7 @@ Atvērt Meklēt Kiwix Bibliotēka - Fails dzēsts + Fails dzēsts turpināt diff --git a/core/src/main/res/values-mk/strings.xml b/core/src/main/res/values-mk/strings.xml index d7e66932c..b40696716 100644 --- a/core/src/main/res/values-mk/strings.xml +++ b/core/src/main/res/values-mk/strings.xml @@ -107,7 +107,7 @@ На линија Библиотека Да го избришам %s? - Податотеката е избришана + Податотеката е избришана Нема податотеки Немате доволно место за преземање на податотекава. Достапен простор: diff --git a/core/src/main/res/values-my/strings.xml b/core/src/main/res/values-my/strings.xml index 1bcefcdb2..f1111dcf3 100644 --- a/core/src/main/res/values-my/strings.xml +++ b/core/src/main/res/values-my/strings.xml @@ -60,7 +60,7 @@ စက်ပစ္စည်း အွန်လိုင်း မှတ်ထားမှုများ - ဖိုင် ဖျက်ပြီးပြီ + ဖိုင် ဖျက်ပြီးပြီ ဤနေရာတွင် ဖိုင်များမရှိပါ ဤဖိုင်ကို ဒေါင်းလုပ်ရယူရန် နေရာလွတ် မလုံလောက်ပါ။ နေရာလွတ် ရရှိနိုင်မှု- diff --git a/core/src/main/res/values-ne/strings.xml b/core/src/main/res/values-ne/strings.xml index ba08fa24e..ebe94e3cf 100644 --- a/core/src/main/res/values-ne/strings.xml +++ b/core/src/main/res/values-ne/strings.xml @@ -64,7 +64,7 @@ लेख नयाँ ट्याबमा खोल्नुहोस् उपकरण पुस्तकालय - फाइल मेटियो + फाइल मेटियो यहाँ कुनै फाइलहरू छैनन् यो फाइल डाउनलोड गर्न पर्याप्त स्थान छैन। साधारण diff --git a/core/src/main/res/values-oc/strings.xml b/core/src/main/res/values-oc/strings.xml index 9aafe9f32..efc74f751 100644 --- a/core/src/main/res/values-oc/strings.xml +++ b/core/src/main/res/values-oc/strings.xml @@ -70,7 +70,7 @@ Aparelh En linha Bibliotèca - Fichièr suprimit + Fichièr suprimit Pas cap de fichièr aicí Espaci disponible : Simple diff --git a/core/src/main/res/values-pl/strings.xml b/core/src/main/res/values-pl/strings.xml index 153e60d26..b04f8f794 100644 --- a/core/src/main/res/values-pl/strings.xml +++ b/core/src/main/res/values-pl/strings.xml @@ -115,7 +115,7 @@ Dostępny Biblioteka Usunąć %s? - Plik został usunięty + Plik został usunięty Tu nie ma plików Za mało miejsca, aby pobrać ten plik. Dostępne miejsce: diff --git a/core/src/main/res/values-pt-rBR/strings.xml b/core/src/main/res/values-pt-rBR/strings.xml index cb56c976b..c92586eea 100644 --- a/core/src/main/res/values-pt-rBR/strings.xml +++ b/core/src/main/res/values-pt-rBR/strings.xml @@ -113,7 +113,7 @@ Online Biblioteca Excluir %s? - Arquivo apagado + Arquivo apagado Nenhum arquivo aqui Espaço insuficiente para baixar este arquivo. Espaço disponível: diff --git a/core/src/main/res/values-pt/strings.xml b/core/src/main/res/values-pt/strings.xml index 3881c458a..a8300329b 100644 --- a/core/src/main/res/values-pt/strings.xml +++ b/core/src/main/res/values-pt/strings.xml @@ -86,7 +86,7 @@ Dispositivo Ligado Biblioteca - Ficheiro apagado + Ficheiro apagado Não há ficheiros aqui Espaço insuficiente para o download deste ficheiro. Espaço disponível: diff --git a/core/src/main/res/values-ro/strings.xml b/core/src/main/res/values-ro/strings.xml index b8a3770ce..d49f853ae 100644 --- a/core/src/main/res/values-ro/strings.xml +++ b/core/src/main/res/values-ro/strings.xml @@ -80,7 +80,7 @@ Dispozitiv Online Bibliotecă - Filă ștearsă + Filă ștearsă Nu sunt fișiere aici Spațiu insuficient pentru a descarca această filă. Spațiu disponibil: diff --git a/core/src/main/res/values-ru/strings.xml b/core/src/main/res/values-ru/strings.xml index 892c01f36..6e00d2ff8 100644 --- a/core/src/main/res/values-ru/strings.xml +++ b/core/src/main/res/values-ru/strings.xml @@ -88,7 +88,7 @@ Устройство Онлайн Библиотека - Файл удалён + Файл удалён Файлы отсутствуют Недостаточно места для загрузки этого файла. Доступно Места: diff --git a/core/src/main/res/values-sc/strings.xml b/core/src/main/res/values-sc/strings.xml index 0e39762a9..b1feb41a7 100644 --- a/core/src/main/res/values-sc/strings.xml +++ b/core/src/main/res/values-sc/strings.xml @@ -105,7 +105,7 @@ In lìnia Biblioteca Iscantzellare %s? - Documentu iscantzelladu + Documentu iscantzelladu Perunu documentu inoghe Sa memòria non bastat pro iscarrigare custu documentu. Ispàtziu disponìbile: diff --git a/core/src/main/res/values-sl/strings.xml b/core/src/main/res/values-sl/strings.xml index a06777d6f..a5615b2b7 100644 --- a/core/src/main/res/values-sl/strings.xml +++ b/core/src/main/res/values-sl/strings.xml @@ -85,7 +85,7 @@ Naprava Na spletu Knjižnica - Datoteka je izbrisana + Datoteka je izbrisana Ni datotek tukaj Premalo prostora za prenos te datoteke. Prostor na voljo: diff --git a/core/src/main/res/values-sq/strings.xml b/core/src/main/res/values-sq/strings.xml index 1daecfb62..f443bfd63 100644 --- a/core/src/main/res/values-sq/strings.xml +++ b/core/src/main/res/values-sq/strings.xml @@ -77,7 +77,7 @@ Pajisje Në linjë Bibliotekë - Kartela u fshi + Kartela u fshi S’ka kartela këtu Hapësirë e pamjaftueshme për shkarkimin e kësaj kartele. Hapësirë e Përdorshme: diff --git a/core/src/main/res/values-sr/strings.xml b/core/src/main/res/values-sr/strings.xml index bcaca8ccc..ab7ace4c2 100644 --- a/core/src/main/res/values-sr/strings.xml +++ b/core/src/main/res/values-sr/strings.xml @@ -62,7 +62,7 @@ Када отвараш нову картицу она ће бити отворена у позадини Чланак је отворен у новој картици Уређај - Датотека је избрисана + Датотека је избрисана Овде нема датотека Недовољно простора за преузимање ове датотеке. Нема мрежне везе diff --git a/core/src/main/res/values-su/strings.xml b/core/src/main/res/values-su/strings.xml index 916005c93..f016b2aaa 100644 --- a/core/src/main/res/values-su/strings.xml +++ b/core/src/main/res/values-su/strings.xml @@ -24,7 +24,7 @@ Buka Markah dipupus Pabukon - Berkas geus dipupus + Berkas geus dipupus Euweuh berkas di dieu Rohang teu nyukupan pikeun ngundeur ieu berkas. Euweuh sambungan jaringan diff --git a/core/src/main/res/values-sv/strings.xml b/core/src/main/res/values-sv/strings.xml index f14b6a4db..721211807 100644 --- a/core/src/main/res/values-sv/strings.xml +++ b/core/src/main/res/values-sv/strings.xml @@ -94,7 +94,7 @@ Ansluten Bibliotek Radera %s? - Fil raderades + Fil raderades Inga filer här Otillräckligt utrymme för att ladda ned denna fil. Tillgängligt utrymme: diff --git a/core/src/main/res/values-th/strings.xml b/core/src/main/res/values-th/strings.xml index f6aa1b6f5..e7f203cfa 100644 --- a/core/src/main/res/values-th/strings.xml +++ b/core/src/main/res/values-th/strings.xml @@ -31,7 +31,7 @@ ทีหลัง ลบบุ๊คมาร์คแล้ว รายการ - ไฟล์ถูกลบ + ไฟล์ถูกลบ พื้นที่ไม่เพียงพอในการดาวน์โหลดไฟล์นี้ คุณสามารถดาวน์โหลดไฟล์ ZIM ที่คุณเลือกในแอพหรือเลือกไฟล์ที่คุณต้องการและดาวน์โหลดจากคอมพิวเตอร์เดสก์ท็อปอย่างระมัดระวังก่อนที่จะถ่ายโอนไฟล์ ZIM ไปยังเอสดีการ์ดของคุณ การดาวน์โหลดไฟล์ ZIM ในแอพจะอยู่ในไดเรกทอรีจัดเก็บข้อมูลภายนอกในโฟลเดอร์ชื่อ Kiwix diff --git a/core/src/main/res/values-tr/strings.xml b/core/src/main/res/values-tr/strings.xml index cd3790c54..85fb51082 100644 --- a/core/src/main/res/values-tr/strings.xml +++ b/core/src/main/res/values-tr/strings.xml @@ -118,7 +118,7 @@ Çevrimiçi Kütüphane %s silinsin mi? - Dosya silindi + Dosya silindi Dosya yok Bu dosyanın indirilebilmesi için yeterli alan yok. Kullanılabilir Alan: diff --git a/core/src/main/res/values-uk/strings.xml b/core/src/main/res/values-uk/strings.xml index 37d15f4b8..2d8713638 100644 --- a/core/src/main/res/values-uk/strings.xml +++ b/core/src/main/res/values-uk/strings.xml @@ -81,7 +81,7 @@ Пристрій Онлайн Бібліотека - Файл вилучено + Файл вилучено Тут немає файлів Недостатньо простору для завантаження цього файлу. Доступний простір: diff --git a/core/src/main/res/values-vi/strings.xml b/core/src/main/res/values-vi/strings.xml index c4cdd8042..8c0c38cb1 100644 --- a/core/src/main/res/values-vi/strings.xml +++ b/core/src/main/res/values-vi/strings.xml @@ -80,7 +80,7 @@ Thiết bị Trực tuyến Thư viện - Đã xóa tập tin + Đã xóa tập tin Không có tập tin nào ở đây Không đủ dung lượng trống để tải về tập tin này. Dung lượng trống còn lại: diff --git a/core/src/main/res/values-xmf/strings.xml b/core/src/main/res/values-xmf/strings.xml index 42b8a04d2..f48f12e00 100644 --- a/core/src/main/res/values-xmf/strings.xml +++ b/core/src/main/res/values-xmf/strings.xml @@ -84,7 +84,7 @@ ონლაინ ბიბლიოთეკა დობლასათო %s? - ფაილქ დილასუ + ფაილქ დილასუ ფაილეფი ვა რე თე ფაილიშ გიმახარგალო შვენა ვაბაღუ. ხემიოჭირინაფუ შვენა: diff --git a/core/src/main/res/values-zh-rTW/strings.xml b/core/src/main/res/values-zh-rTW/strings.xml index ecd3ccf18..98d0b7ab2 100644 --- a/core/src/main/res/values-zh-rTW/strings.xml +++ b/core/src/main/res/values-zh-rTW/strings.xml @@ -112,7 +112,7 @@ 線上 圖書館 刪除%s? - 檔案已刪除 + 檔案已刪除 沒有檔案在此 沒有足夠的空間來下載此檔案。 可用空間: diff --git a/core/src/main/res/values-zh/strings.xml b/core/src/main/res/values-zh/strings.xml index 1453758ed..4083b12a3 100644 --- a/core/src/main/res/values-zh/strings.xml +++ b/core/src/main/res/values-zh/strings.xml @@ -87,7 +87,7 @@ 设备 在线 图书馆 - 文件已删除 + 文件已删除 没有文件 缺少下载此文件所需的空间。 可用空间: diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml index 71f994bd8..6bb5e76df 100644 --- a/core/src/main/res/values/strings.xml +++ b/core/src/main/res/values/strings.xml @@ -103,8 +103,8 @@ Device Online Library - Delete %s? - File deleted + The following zim file(s) will be deleted: %s + Files deleted successfully No files here Insufficient space to download. Space Available: @@ -124,7 +124,7 @@ ZIM files download in-app are located in the external storage directory in a folder entitled Kiwix. Storage Current Folder - Sorry we were unable to delete this file. You should try using a file manager instead. + Sorry we were unable to delete some files. You should try using a file manager instead. pause resume stop From fbf7c50f7819cdaade4c60b0d67f7700de12ce94 Mon Sep 17 00:00:00 2001 From: Yash Khare Date: Thu, 9 Apr 2020 21:52:46 +0530 Subject: [PATCH 2/6] Use fold instead of forEach --- .../fileselect_view/effects/DeleteFiles.kt | 22 ++++++------------- core/src/main/res/values/strings.xml | 2 +- 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt index 0efc8a9db..af7c964fe 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt @@ -41,29 +41,21 @@ data class DeleteFiles(private val booksOnDiskListItem: List) : override fun invokeWith(activity: AppCompatActivity) { (activity as ZimManageActivity).cachedComponent.inject(this) - var name = "\n" - booksOnDiskListItem.forEach { - name += "\n" + it.book.title - } + val name = booksOnDiskListItem.joinToString(separator = "\n") { it.book.title } dialogShower.show(DeleteZims(name), { - var allDeleted = true - - booksOnDiskListItem.forEach { - if (deleteSpecificZimFile(it)) { - if (it.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { + val booksDeleted = booksOnDiskListItem.fold(true) { _, book -> + if (deleteSpecificZimFile(book)) { + if (book.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { zimReaderContainer.setZimFile(null) } + true } else { - allDeleted = false + false } } - if (allDeleted) { - activity.toast(R.string.delete_zims_toast) - } else { - activity.toast(R.string.delete_zim_failed) - } + activity.toast(if (booksDeleted) R.string.delete_zims_toast else R.string.delete_zim_failed) }) } diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml index 6bb5e76df..08706b472 100644 --- a/core/src/main/res/values/strings.xml +++ b/core/src/main/res/values/strings.xml @@ -103,7 +103,7 @@ Device Online Library - The following zim file(s) will be deleted: %s + The following zim file(s) will be deleted:\n\n%s Files deleted successfully No files here Insufficient space to download. From ce6ded65d23e4a980bd27c29c9d9ead0fb0cdc07 Mon Sep 17 00:00:00 2001 From: Yash Khare Date: Thu, 9 Apr 2020 22:01:31 +0530 Subject: [PATCH 3/6] Update booksOnDiskListItem variable name --- .../fileselect_view/effects/DeleteFiles.kt | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt index af7c964fe..74090a50d 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt @@ -31,7 +31,7 @@ import org.kiwix.kiwixmobile.core.zim_manager.fileselect_view.adapter.BooksOnDis import org.kiwix.kiwixmobile.zim_manager.ZimManageActivity import javax.inject.Inject -data class DeleteFiles(private val booksOnDiskListItem: List) : +data class DeleteFiles(private val booksOnDiskListItems: List) : SideEffect { @Inject lateinit var dialogShower: DialogShower @@ -41,18 +41,19 @@ data class DeleteFiles(private val booksOnDiskListItem: List) : override fun invokeWith(activity: AppCompatActivity) { (activity as ZimManageActivity).cachedComponent.inject(this) - val name = booksOnDiskListItem.joinToString(separator = "\n") { it.book.title } + val name = booksOnDiskListItems.joinToString(separator = "\n") { it.book.title } dialogShower.show(DeleteZims(name), { - val booksDeleted = booksOnDiskListItem.fold(true) { _, book -> - if (deleteSpecificZimFile(book)) { - if (book.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { - zimReaderContainer.setZimFile(null) - } - true - } else { - false - } + val booksDeleted = booksOnDiskListItems.fold(true) { acc, book -> + acc && + (if (deleteSpecificZimFile(book)) { + if (book.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { + zimReaderContainer.setZimFile(null) + } + true + } else { + false + }) } activity.toast(if (booksDeleted) R.string.delete_zims_toast else R.string.delete_zim_failed) From 7ef0054dd19a44e76704992985a0661fdafcf40f Mon Sep 17 00:00:00 2001 From: Yash Khare Date: Tue, 14 Apr 2020 13:18:38 +0530 Subject: [PATCH 4/6] Use also and fold to improve zim deletion --- .../fileselect_view/effects/DeleteFiles.kt | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt index 74090a50d..2611a7144 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt @@ -45,15 +45,11 @@ data class DeleteFiles(private val booksOnDiskListItems: List) : dialogShower.show(DeleteZims(name), { val booksDeleted = booksOnDiskListItems.fold(true) { acc, book -> - acc && - (if (deleteSpecificZimFile(book)) { - if (book.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { - zimReaderContainer.setZimFile(null) - } - true - } else { - false - }) + acc && deleteSpecificZimFile(book).also { + if (it && book.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { + zimReaderContainer.setZimFile(null) + } + } } activity.toast(if (booksDeleted) R.string.delete_zims_toast else R.string.delete_zim_failed) From 537b2be914a84f54e26bf806191b0ef401deeb85 Mon Sep 17 00:00:00 2001 From: Yash Khare Date: Wed, 15 Apr 2020 21:21:18 +0530 Subject: [PATCH 5/6] Use an extension function to delete zims --- .../fileselect_view/effects/DeleteFiles.kt | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt index 2611a7144..915a0c3f7 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt @@ -44,16 +44,22 @@ data class DeleteFiles(private val booksOnDiskListItems: List) : val name = booksOnDiskListItems.joinToString(separator = "\n") { it.book.title } dialogShower.show(DeleteZims(name), { - val booksDeleted = booksOnDiskListItems.fold(true) { acc, book -> - acc && deleteSpecificZimFile(book).also { - if (it && book.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { - zimReaderContainer.setZimFile(null) - } + activity.toast( + if (booksOnDiskListItems.deleteAll()) + R.string.delete_zims_toast else + R.string.delete_zim_failed + ) + }) + } + + private fun List.deleteAll(): Boolean { + return this.fold(true) { acc, book -> + acc && deleteSpecificZimFile(book).also { + if (it && book.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { + zimReaderContainer.setZimFile(null) } } - - activity.toast(if (booksDeleted) R.string.delete_zims_toast else R.string.delete_zim_failed) - }) + } } private fun deleteSpecificZimFile(book: BookOnDisk): Boolean { From 3be699c9949b24c4f4389c99e0e0c8bbd1552175 Mon Sep 17 00:00:00 2001 From: Yash Khare Date: Wed, 15 Apr 2020 23:18:35 +0530 Subject: [PATCH 6/6] Improve formatting and omit this --- .../zim_manager/fileselect_view/effects/DeleteFiles.kt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt index 915a0c3f7..cd87a9aeb 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/effects/DeleteFiles.kt @@ -45,15 +45,17 @@ data class DeleteFiles(private val booksOnDiskListItems: List) : dialogShower.show(DeleteZims(name), { activity.toast( - if (booksOnDiskListItems.deleteAll()) - R.string.delete_zims_toast else + if (booksOnDiskListItems.deleteAll()) { + R.string.delete_zims_toast + } else { R.string.delete_zim_failed + } ) }) } private fun List.deleteAll(): Boolean { - return this.fold(true) { acc, book -> + return fold(true) { acc, book -> acc && deleteSpecificZimFile(book).also { if (it && book.file.canonicalPath == zimReaderContainer.zimCanonicalPath) { zimReaderContainer.setZimFile(null)