diff --git a/app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt b/app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt index 1c5364863..db8d65671 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt @@ -22,7 +22,6 @@ import android.Manifest import android.annotation.SuppressLint import android.app.Activity import android.content.Intent -import android.content.pm.PackageManager import android.content.pm.PackageManager.PERMISSION_GRANTED import android.net.ConnectivityManager import android.os.Build @@ -114,12 +113,6 @@ class OnlineLibraryFragment : BaseFragment(), FragmentActivityExtensions { private val isNotConnected get() = conMan.activeNetworkInfo?.isConnected == false - private val isWriteStoragePermissionAllowed - get() = ContextCompat.checkSelfPermission( - requireActivity(), - Manifest.permission.WRITE_EXTERNAL_STORAGE - ) == PackageManager.PERMISSION_GRANTED - override fun inject(baseActivity: BaseActivity) { baseActivity.cachedComponent.inject(this) } @@ -330,12 +323,16 @@ class OnlineLibraryFragment : BaseFragment(), FragmentActivityExtensions { grantResults.isNotEmpty() && grantResults[0] != PERMISSION_GRANTED ) { + context.toast(R.string.request_storage) requestExternalStoragePermission() } } + private fun hasPermission(permission: String): Boolean = + ContextCompat.checkSelfPermission(requireActivity(), permission) == PERMISSION_GRANTED + private fun onBookItemClick(item: LibraryListItem.BookItem) { - if (isWriteStoragePermissionAllowed) { + if (hasPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE)) { when { isNotConnected -> { noInternetSnackbar()