kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-08-03 18:56:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Share button is not working in Device Fragment #945

Browse Source
This commit is contained in:
prajurock 2019-02-11 08:53:02 +05:30 committed by Isaac Hutt
parent b780880627
commit 2f207ac361
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
app/src/main/java/org/kiwix/kiwixmobile/zim_manager/fileselect_view/ZimFileSelectFragment.java
View File

@ -120,7 +120,7 @@ public class ZimFileSelectFragment extends BaseFragment
// A boolean to distinguish between a user refresh and a normal loading // A boolean to distinguish between a user refresh and a normal loading
mHasRefresh = false; mHasRefresh = false;
mRescanAdapter = new RescanDataAdapter(zimManageActivity, 0, mFiles); mRescanAdapter = new RescanDataAdapter(zimManageActivity, mFiles);
// Allow temporary use of ZimContentProvider to query books // Allow temporary use of ZimContentProvider to query books
ZimContentProvider.canIterate = true; ZimContentProvider.canIterate = true;
@ -130,7 +130,7 @@ public class ZimFileSelectFragment extends BaseFragment
mZimFileList.setMultiChoiceModeListener(new AbsListView.MultiChoiceModeListener() { mZimFileList.setMultiChoiceModeListener(new AbsListView.MultiChoiceModeListener() {
// Holds positions corresponding to every selected list item in the ListView // Holds positions corresponding to every selected list item in the ListView
private ArrayList<Integer> selectedViewPosition = new ArrayList<>(); private final ArrayList<Integer> selectedViewPosition = new ArrayList<>();
@Override @Override
public void onItemCheckedStateChanged(ActionMode mode, int position, long id, public void onItemCheckedStateChanged(ActionMode mode, int position, long id,
@ -194,7 +194,7 @@ public class ZimFileSelectFragment extends BaseFragment
selectedViewPosition.get(i)); selectedViewPosition.get(i));
String shareFilePath = data.file.getPath(); //Returns path to file in device storage String shareFilePath = data.file.getPath(); //Returns path to file in device storage
/** /*
* Using 'file:///' URIs directly is unsafe as it grants the intent receiving application * Using 'file:///' URIs directly is unsafe as it grants the intent receiving application
* the same file system permissions as the intent creating app. * the same file system permissions as the intent creating app.
* *
@ -204,8 +204,13 @@ public class ZimFileSelectFragment extends BaseFragment
*/ */
File shareFile = new File(shareFilePath); File shareFile = new File(shareFilePath);
Uri shareContentUri = FileProvider.getUriForFile(getContext(), Uri shareContentUri;
BuildConfig.APPLICATION_ID + ".fileprovider", shareFile); if (Build.VERSION.SDK_INT >= 24) {
shareContentUri = FileProvider.getUriForFile(zimManageActivity,
BuildConfig.APPLICATION_ID + ".fileprovider", shareFile);
} else {
shareContentUri = Uri.fromFile(shareFile);
}
if (shareContentUri != null) { if (shareContentUri != null) {
selectedFileContentURIs.add( selectedFileContentURIs.add(
@ -216,19 +221,18 @@ public class ZimFileSelectFragment extends BaseFragment
selectedFileShareIntent.putParcelableArrayListExtra(Intent.EXTRA_STREAM, selectedFileShareIntent.putParcelableArrayListExtra(Intent.EXTRA_STREAM,
selectedFileContentURIs); // Intent Extra for storing the array list of selected file content URIs selectedFileContentURIs); // Intent Extra for storing the array list of selected file content URIs
if (selectedFileContentURIs // Grant temporary access permission to the intent receiver for the content URIs
!= null) { // Grant temporary access permission to the intent receiver for the content URIs selectedFileShareIntent.setFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
selectedFileShareIntent.setFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
}
/** /*
* Since a different app may be used for sharing everytime (E-mail, Cloud Upload, Wifi Sharing, etc.), * Since a different app may be used for sharing everytime (E-mail, Cloud Upload, Wifi Sharing, etc.),
* so force an app chooser dialog every time some selected files are to be shared. * so force an app chooser dialog every time some selected files are to be shared.
*/ */
Intent shareChooserIntent = Intent.createChooser(selectedFileShareIntent, Intent shareChooserIntent = Intent.createChooser(selectedFileShareIntent,
getResources().getString(R.string.selected_file_cab_app_chooser_title)); getResources().getString(R.string.selected_file_cab_app_chooser_title));
if (shareChooserIntent.resolveActivity(getActivity().getPackageManager()) != null) { if (shareChooserIntent.resolveActivity(zimManageActivity.getPackageManager()) != null) {
startActivity(shareChooserIntent); // Open the app chooser dialog startActivity(shareChooserIntent); // Open the app chooser dialog
} }
@ -467,9 +471,8 @@ public class ZimFileSelectFragment extends BaseFragment
// The Adapter for the ListView for when the ListView is populated with the rescanned files // The Adapter for the ListView for when the ListView is populated with the rescanned files
private class RescanDataAdapter extends ArrayAdapter<LibraryNetworkEntity.Book> { private class RescanDataAdapter extends ArrayAdapter<LibraryNetworkEntity.Book> {
RescanDataAdapter(Context context, int textViewResourceId, RescanDataAdapter(Context context, List<LibraryNetworkEntity.Book> objects) {
List<LibraryNetworkEntity.Book> objects) { super(context, 0, objects);
super(context, textViewResourceId, objects);
} }
@NonNull @NonNull