Merge pull request #2133 from kiwix/macgills/feature/2131-broken-instrumentation

#2131 PR instrumentation tests can fail silently

.github/workflows/nightly.yml

@@ -21,11 +21,18 @@ jobs:
           fetch-depth: 1
 
       - name: run instrumentation tests
-        uses: reactivecircus/android-emulator-runner@v2.0.0
+        uses: ReactiveCircus/android-emulator-runner@v2.8.0
         with:
           api-level: ${{ matrix.api-level }}
           arch: x86_64
-          script: ./gradlew connectedDebugAndroidTest
+          script: bash contrib/instrumentation_nightly.sh
+
+      - name: Upload screenshot result
+        uses: actions/upload-artifact@v1
+        if: failure()
+        with:
+          name: ${{ matrix.api-level }}
+          path: screencap.png
 
   unit_test_and_release:
     runs-on: ubuntu-latest

contrib/instrumentation.sh

@@ -2,6 +2,9 @@
 
 adb logcat -c
 adb logcat *:E -v color &
-./gradlew jacocoInstrumentationTestReport
+if ./gradlew jacocoInstrumentationTestReport; then
+  echo "jacocoInstrumentationTestReport succeeded" >&2
+else
   adb exec-out screencap -p >screencap.png
-find screencap.png
+  echo "jacocoInstrumentationTestReport failed" >&2
+fi

contrib/instrumentation_nightly.sh

@@ -0,0 +1,10 @@
+#!/usr/bin/env bash
+
+adb logcat -c
+adb logcat *:E -v color &
+if ./gradlew connectedDebugAndroidTest; then
+  echo "connectedDebugAndroidTest succeeded" >&2
+else
+  adb exec-out screencap -p >screencap.png
+  echo "connectedDebugAndroidTest failed" >&2
+fi