kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-08-04 03:06:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed, Bookmark toggle is not on when opening bookmarks for existing opened book.

Browse Source 
* Fixed the issue by correctly setting up the bookmark disposable for the current ZIM file when opening bookmarks for the currently opened book.
This commit is contained in:
MohitMaliFtechiz 2023-11-21 16:02:38 +05:30
parent 43e6ce6bee
commit 46b51bb710
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/kiwix/kiwixmobile/nav/destination/reader/KiwixReaderFragment.kt
View File

@ -89,6 +89,12 @@ class KiwixReaderFragment : CoreReaderFragment() {
if (args.pageUrl.isNotEmpty()) { if (args.pageUrl.isNotEmpty()) {
if (args.zimFileUri.isNotEmpty()) { if (args.zimFileUri.isNotEmpty()) {
tryOpeningZimFile(args.zimFileUri) tryOpeningZimFile(args.zimFileUri)
} else {
// Set up bookmarks for the current book when opening bookmarks from the Bookmark screen.
// This is necessary because we are not opening the ZIM file again; the bookmark is
// inside the currently opened book. Bookmarks are set up when opening the ZIM file.
// See https://github.com/kiwix/kiwix-android/issues/3541
zimReaderContainer?.zimFileReader?.let(::setUpBookmarks)
} }
loadUrlWithCurrentWebview(args.pageUrl) loadUrlWithCurrentWebview(args.pageUrl)
} else { } else {