From 4b21258442c0d90fef72c7c5332ced1b8880f0ac Mon Sep 17 00:00:00 2001 From: Adeel Zafar Date: Sat, 17 Aug 2019 01:56:32 +0500 Subject: [PATCH] Resolve Java warnings --- .../org/kiwix/kiwixmobile/webserver/ZimHostActivity.java | 2 +- .../org/kiwix/kiwixmobile/webserver/ZimHostCallbacks.java | 7 ++++--- .../kiwix/kiwixmobile/wifi_hotspot/WifiHotspotManager.java | 5 ++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/webserver/ZimHostActivity.java b/app/src/main/java/org/kiwix/kiwixmobile/webserver/ZimHostActivity.java index e4aa10767..40c789348 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/webserver/ZimHostActivity.java +++ b/app/src/main/java/org/kiwix/kiwixmobile/webserver/ZimHostActivity.java @@ -505,7 +505,7 @@ public class ZimHostActivity extends BaseActivity implements }); } - @Override public void onHotspotStateReceived(@Nullable Boolean isHotspotEnabled) { + @Override public void onHotspotStateReceived(@NonNull Boolean isHotspotEnabled) { if (isHotspotEnabled) //if hotspot is already enabled, turn it off. { startService(ACTION_TURN_OFF_AFTER_O); diff --git a/app/src/main/java/org/kiwix/kiwixmobile/webserver/ZimHostCallbacks.java b/app/src/main/java/org/kiwix/kiwixmobile/webserver/ZimHostCallbacks.java index 586480da3..98b01e735 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/webserver/ZimHostCallbacks.java +++ b/app/src/main/java/org/kiwix/kiwixmobile/webserver/ZimHostCallbacks.java @@ -1,18 +1,19 @@ package org.kiwix.kiwixmobile.webserver; import android.net.wifi.WifiConfiguration; +import androidx.annotation.NonNull; public interface ZimHostCallbacks { - void onServerStarted(String ip); + void onServerStarted(@NonNull String ip); void onServerStopped(); void onServerFailedToStart(); - void onHotspotTurnedOn(WifiConfiguration wifiConfiguration); + void onHotspotTurnedOn(@NonNull WifiConfiguration wifiConfiguration); void onHotspotFailedToStart(); - void onHotspotStateReceived(Boolean state); + void onHotspotStateReceived(@NonNull Boolean state); } diff --git a/app/src/main/java/org/kiwix/kiwixmobile/wifi_hotspot/WifiHotspotManager.java b/app/src/main/java/org/kiwix/kiwixmobile/wifi_hotspot/WifiHotspotManager.java index 39eaaf81e..6dda8906c 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/wifi_hotspot/WifiHotspotManager.java +++ b/app/src/main/java/org/kiwix/kiwixmobile/wifi_hotspot/WifiHotspotManager.java @@ -18,13 +18,12 @@ import org.kiwix.kiwixmobile.webserver.ZimHostCallbacks; public class WifiHotspotManager { private final WifiManager wifiManager; - private final Context context; WifiManager.LocalOnlyHotspotReservation hotspotReservation; private static final String TAG = "WifiHotspotManager"; public WifiHotspotManager(@NonNull Context context) { - this.context = context; - wifiManager = (WifiManager) this.context.getSystemService(Context.WIFI_SERVICE); + wifiManager = + (WifiManager) context.getApplicationContext().getSystemService(Context.WIFI_SERVICE); } //Workaround to turn on hotspot for Oreo versions