From 61dd97ce9a3df6ccfce21dc7507f5956cdfc90bb Mon Sep 17 00:00:00 2001
From: MohitMaliFtechiz <futuretechnoworld.mohit@gmail.com>
Date: Mon, 21 Oct 2024 15:39:53 +0530
Subject: [PATCH] Attaching the device logs in the email body instead of as a
 file.

* We cannot attach a file to the email when using the `ACTION_SENDTO` action in the intent. However, we must use this intent action because it is the only one handled exclusively by email apps. This ensures that only email apps appear in the suggestions.
---
 .../kiwixmobile/core/error/ErrorActivity.kt   | 19 ++-----------------
 core/src/main/res/values/strings.xml          |  1 +
 2 files changed, 3 insertions(+), 17 deletions(-)

diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/error/ErrorActivity.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/error/ErrorActivity.kt
index ace1d4875..9a51bbb90 100644
--- a/core/src/main/java/org/kiwix/kiwixmobile/core/error/ErrorActivity.kt
+++ b/core/src/main/java/org/kiwix/kiwixmobile/core/error/ErrorActivity.kt
@@ -25,7 +25,6 @@ import android.os.Bundle
 import android.os.Process
 import androidx.activity.result.contract.ActivityResultContracts
 import androidx.core.content.ContextCompat
-import androidx.core.content.FileProvider
 import androidx.lifecycle.lifecycleScope
 import kotlinx.coroutines.launch
 import org.kiwix.kiwixmobile.core.CoreApp.Companion.coreComponent
@@ -102,12 +101,7 @@ open class ErrorActivity : BaseActivity() {
         if (activities.isNotEmpty()) {
           sendEmailLauncher.launch(Intent.createChooser(emailIntent, "Send email..."))
         } else {
-          toast(
-            getString(
-              R.string.no_email_application_installed,
-              CRASH_AND_FEEDBACK_EMAIL_ADDRESS
-            )
-          )
+          toast(getString(R.string.no_email_application_installed))
         }
       }
     }
@@ -124,20 +118,11 @@ open class ErrorActivity : BaseActivity() {
       data = Uri.parse("mailto:")
       putExtra(Intent.EXTRA_EMAIL, arrayOf(CRASH_AND_FEEDBACK_EMAIL_ADDRESS))
       putExtra(Intent.EXTRA_SUBJECT, subject)
-      putExtra(Intent.EXTRA_TEXT, emailBody)
       val file = fileLogger.writeLogFile(
         this@ErrorActivity,
         activityKiwixErrorBinding?.allowLogs?.isChecked == true
       )
-      file.appendText(emailBody)
-      val path =
-        FileProvider.getUriForFile(
-          this@ErrorActivity,
-          applicationContext.packageName + ".fileprovider",
-          file
-        )
-      addFlags(android.content.Intent.FLAG_GRANT_READ_URI_PERMISSION)
-      putExtra(android.content.Intent.EXTRA_STREAM, path)
+      putExtra(Intent.EXTRA_TEXT, "$emailBody\n\nDevice Logs:\n$${file.readText()}")
     }
   }
 
diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml
index db7e5aaa9..7ef66a40a 100644
--- a/core/src/main/res/values/strings.xml
+++ b/core/src/main/res/values/strings.xml
@@ -68,6 +68,7 @@
   <string name="pref_credits_title">Credits</string>
   <string name="tts_lang_not_supported">The language of this page is not supported. The article may not be properly read.</string>
   <string name="no_reader_application_installed">Could not find an installed application for this type of file</string>
+  <string name="no_email_application_installed">Please install an email client</string>
   <string name="no_app_found_to_select_bookmark_file">No app found to select a bookmark file</string>
   <string name="no_section_info">No Content Headers Found</string>
   <string name="request_storage">To access offline content we need access to your storage</string>