From 64b001bf0f877acbeeb75cdc976784db42f334e8 Mon Sep 17 00:00:00 2001 From: cdhiraj40 Date: Tue, 28 Dec 2021 12:45:06 +0530 Subject: [PATCH] made completable nullable --- .../src/main/java/org/kiwix/kiwixmobile/core/data/DataSource.kt | 2 +- .../src/main/java/org/kiwix/kiwixmobile/core/data/Repository.kt | 2 +- .../org/kiwix/kiwixmobile/core/main/MainRepositoryActions.kt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/data/DataSource.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/data/DataSource.kt index 392b11134..db64071d2 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/data/DataSource.kt +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/data/DataSource.kt @@ -44,6 +44,6 @@ interface DataSource { fun saveBookmark(bookmark: BookmarkItem): Completable fun deleteBookmarks(bookmarks: List): Completable - fun deleteBookmark(bookmarkUrl: String): Completable + fun deleteBookmark(bookmarkUrl: String): Completable? fun booksOnDiskAsListItems(): Flowable> } diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/data/Repository.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/data/Repository.kt index bc2e8f609..e5bfb6e0b 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/data/Repository.kt +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/data/Repository.kt @@ -115,7 +115,7 @@ class Repository @Inject internal constructor( Completable.fromAction { bookmarksDao.deleteBookmarks(bookmarks) } .subscribeOn(io) - override fun deleteBookmark(bookmarkUrl: String): Completable = + override fun deleteBookmark(bookmarkUrl: String): Completable? = Completable.fromAction { bookmarksDao.deleteBookmark(bookmarkUrl) } .subscribeOn(io) } diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/main/MainRepositoryActions.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/main/MainRepositoryActions.kt index 855605496..c4728b402 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/main/MainRepositoryActions.kt +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/main/MainRepositoryActions.kt @@ -41,6 +41,6 @@ class MainRepositoryActions @Inject constructor(private val dataSource: DataSour fun deleteBookmark(bookmarkUrl: String) { dataSource.deleteBookmark(bookmarkUrl) - .subscribe({}, { e -> Log.e(TAG, "Unable to delete bookmark", e) }) + ?.subscribe({}, { e -> Log.e(TAG, "Unable to delete bookmark", e) }) } }