kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-09 15:27:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed the memory leak on Android 13 and Android 14.

Browse Source
This commit is contained in:
MohitMaliFtechiz 2024-08-28 15:48:46 +05:30 committed by Kelson
parent c88428dbbe
commit 657783e09a
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/org/kiwix/kiwixmobile/language/LanguageFragment.kt
View File

@ -70,6 +70,7 @@ class LanguageFragment : BaseFragment() {
private val compositeDisposable = CompositeDisposable() private val compositeDisposable = CompositeDisposable()
private var activityLanguageBinding: ActivityLanguageBinding? = null private var activityLanguageBinding: ActivityLanguageBinding? = null
private var searchView: SearchView? = null
private val languageAdapter = private val languageAdapter =
LanguageAdapter( LanguageAdapter(
@ -127,8 +128,8 @@ class LanguageFragment : BaseFragment() {
object : MenuProvider { object : MenuProvider {
override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) { override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {
menuInflater.inflate(R.menu.menu_language, menu) menuInflater.inflate(R.menu.menu_language, menu)
val search = menu.findItem(R.id.menu_language_search).actionView as SearchView searchView = menu.findItem(R.id.menu_language_search).actionView as SearchView
search.apply { searchView?.apply {
setUpSearchView(requireActivity()) setUpSearchView(requireActivity())
setOnQueryTextListener( setOnQueryTextListener(
SimpleTextListener { query, _ -> SimpleTextListener { query, _ ->
@ -172,6 +173,8 @@ class LanguageFragment : BaseFragment() {
override fun onDestroyView() { override fun onDestroyView() {
super.onDestroyView() super.onDestroyView()
searchView?.setOnQueryTextListener(null)
searchView = null
activityLanguageBinding = null activityLanguageBinding = null
} }
} }

1
app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/LocalLibraryFragment.kt
View File

@ -489,6 +489,7 @@ class LocalLibraryFragment : BaseFragment(), CopyMoveFileHandler.FileCopyMoveCal
copyMoveFileHandler?.fileCopyMoveCallback = null copyMoveFileHandler?.fileCopyMoveCallback = null
copyMoveFileHandler?.lifecycleScope = null copyMoveFileHandler?.lifecycleScope = null
copyMoveFileHandler?.fileSystemDisposable?.dispose() copyMoveFileHandler?.fileSystemDisposable?.dispose()
copyMoveFileHandler = null
} }
private fun sideEffects() = zimManageViewModel.sideEffects private fun sideEffects() = zimManageViewModel.sideEffects

1
core/src/main/java/org/kiwix/kiwixmobile/core/search/SearchFragment.kt
View File

@ -206,6 +206,7 @@ class SearchFragment : BaseFragment() {
renderingJob?.cancel() renderingJob?.cancel()
renderingJob = null renderingJob = null
activity?.intent?.action = null activity?.intent?.action = null
searchView?.setOnQueryTextListener(null)
searchView = null searchView = null
searchInTextMenuItem = null searchInTextMenuItem = null
findInPageTextView = null findInPageTextView = null