#2128 Upgrade Android Gradle Plugin to 4.0 - upgrade wrapper - explictly set ndk - upgrade AGP

.github/workflows/coverage.yml

@@ -29,6 +29,7 @@ jobs:
         with:
           api-level: ${{ matrix.api-level }}
           arch: x86_64
+          ndk: 21.1.6352462
           script: bash contrib/instrumentation.sh
 
       - name: Upload screenshot result

.github/workflows/nightly.yml

@@ -25,6 +25,7 @@ jobs:
         with:
           api-level: ${{ matrix.api-level }}
           arch: x86_64
+          ndk: 21.1.6352462
           script: bash contrib/instrumentation_nightly.sh
 
       - name: Upload screenshot result

buildSrc/build.gradle.kts

@@ -11,7 +11,7 @@ repositories {
 }
 
 dependencies {
-  implementation("com.android.tools.build:gradle:3.5.3")
+  implementation("com.android.tools.build:gradle:4.0.0")
   implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.72")
   implementation("com.hiya:jacoco-android:0.2")
   implementation("org.jlleitschuh.gradle:ktlint-gradle:9.2.1")

buildSrc/src/main/kotlin/Versions.kt

@@ -34,7 +34,7 @@ object Versions {
 
   const val android_arch_lifecycle_extensions: String = "1.1.1"
 
-  const val com_android_tools_build_gradle: String = "3.5.3" // available: "4.0.0"
+  const val com_android_tools_build_gradle: String = "4.0.0"
 
   const val de_fayard_buildsrcversions_gradle_plugin: String = "0.7.0"
 

buildSrc/src/main/kotlin/plugin/AllProjectConfigurer.kt

@@ -47,7 +47,7 @@ class AllProjectConfigurer {
   fun configureBaseExtension(target: Project, path: String) {
     target.configureExtension<BaseExtension> {
       setCompileSdkVersion(Config.compileSdk)
-
+      ndkVersion = "21.1.6352462"
       defaultConfig {
         setMinSdkVersion(Config.minSdk)
         setTargetSdkVersion(Config.targetSdk)
@@ -98,6 +98,7 @@ class AllProjectConfigurer {
         ignore(
           "SyntheticAccessor",
           "GoogleAppIndexingApiWarning",
+          "LockedOrientationActivity",
           //TODO stop ignoring below this
           "CheckResult",
           "LabelFor",

gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.0.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip