From 951a07367858741a1036152c44dbc665c32ef8b8 Mon Sep 17 00:00:00 2001 From: cdhiraj40 Date: Sat, 20 Nov 2021 19:28:17 +0530 Subject: [PATCH] kiwix#2717 requested changes done --- .../nav/destination/library/OnlineLibraryFragment.kt | 2 +- .../core/utils/SimpleRecyclerViewScrollListener.kt | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt b/app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt index b1c2cc1b6..4453b0818 100644 --- a/app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt +++ b/app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt @@ -274,5 +274,5 @@ class OnlineLibraryFragment : BaseFragment(), FragmentActivityExtensions { .apply { onSelectAction = ::storeDeviceInPreferences } - .show(parentFragmentManager, getString(R.string.pref_storage)) + .show(requireFragmentManager(), getString(R.string.pref_storage)) } diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/utils/SimpleRecyclerViewScrollListener.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/utils/SimpleRecyclerViewScrollListener.kt index ddd36b0b2..64d5614c9 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/utils/SimpleRecyclerViewScrollListener.kt +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/utils/SimpleRecyclerViewScrollListener.kt @@ -21,7 +21,7 @@ package org.kiwix.kiwixmobile.core.utils import androidx.recyclerview.widget.RecyclerView class SimpleRecyclerViewScrollListener( - private val onLayoutScrollListener: (RecyclerView, Int) -> Unit // here we are calling callback + private val onLayoutScrollListener: (RecyclerView, Int) -> Unit ) : RecyclerView.OnScrollListener() { override fun onScrollStateChanged(recyclerView: RecyclerView, newState: Int) { @@ -29,10 +29,6 @@ class SimpleRecyclerViewScrollListener( onLayoutScrollListener( recyclerView, newState - ) // implement the callback by passing recyclerview and newState - super.onScrollStateChanged(recyclerView, newState) + ) } } - - -