kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-08-03 18:56:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed extra space on the webview top if the webview is not atteched to any view

Browse Source
This commit is contained in:
MohitMaliFtechiz 2023-06-23 15:14:39 +05:30 committed by Kelson
parent 17cbcf082d
commit a3de2a25c7
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreReaderFragment.kt
View File

@ -686,15 +686,18 @@ abstract class CoreReaderFragment :
*/
protected open fun setTopMarginToWebViews(topMargin: Int) {
for (webView in webViewList) {
webView.parent?.let {
if (webView.parent == null) {
// Ensure that the web view has a parent before modifying its layout parameters
// This check is necessary to prevent adding the margin when the web view is not attached to a layout
// Adding the margin without a parent can cause unintended layout issues or empty
// space on top of the webView in the tabs adapter.
val layoutParams = webView.layoutParams as FrameLayout.LayoutParams?
layoutParams?.topMargin = topMargin
webView.requestLayout()
val frameLayout = FrameLayout(requireActivity())
// Add the web view to the frame layout
frameLayout.addView(webView)
}
val layoutParams = webView.layoutParams as FrameLayout.LayoutParams?
layoutParams?.topMargin = topMargin
webView.requestLayout()
}
}