kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-11 00:23:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

Removed deprecated method, unused code and fixed lint error

Browse Source
This commit is contained in:
MohitMaliFtechiz 2023-03-21 15:12:38 +05:30 committed by Kelson
parent 7d651ff382
commit ae62813dce
2 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/OnlineLibraryFragment.kt
View File

@ -146,7 +146,6 @@ class OnlineLibraryFragment : BaseFragment(), FragmentActivityExtensions {
container: ViewGroup?, container: ViewGroup?,
savedInstanceState: Bundle? savedInstanceState: Bundle?
): View? { ): View? {
setHasOptionsMenu(true)
fragmentDestinationDownloadBinding = fragmentDestinationDownloadBinding =
FragmentDestinationDownloadBinding.inflate(inflater, container, false) FragmentDestinationDownloadBinding.inflate(inflater, container, false)
val toolbar = fragmentDestinationDownloadBinding?.root?.findViewById<Toolbar>(R.id.toolbar) val toolbar = fragmentDestinationDownloadBinding?.root?.findViewById<Toolbar>(R.id.toolbar)
@ -266,16 +265,6 @@ class OnlineLibraryFragment : BaseFragment(), FragmentActivityExtensions {
} }
} }
override fun onOptionsItemSelected(item: MenuItem): Boolean {
when (item.itemId) {
R.id.select_language -> {
requireActivity().navigate(R.id.languageFragment)
closeKeyboard()
}
}
return super.onOptionsItemSelected(item)
}
override fun onDestroyView() { override fun onDestroyView() {
super.onDestroyView() super.onDestroyView()
availableSpaceCalculator.dispose() availableSpaceCalculator.dispose()

5
core/src/main/java/org/kiwix/kiwixmobile/core/page/PageFragment.kt
View File

@ -94,10 +94,6 @@ abstract class PageFragment : OnItemClickListener, BaseFragment(), FragmentActiv
} }
} }
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
}
private fun setupMenu() { private fun setupMenu() {
(requireActivity() as MenuHost).addMenuProvider( (requireActivity() as MenuHost).addMenuProvider(
object : MenuProvider { object : MenuProvider {
@ -112,6 +108,7 @@ abstract class PageFragment : OnItemClickListener, BaseFragment(), FragmentActiv
) )
} }
@Suppress("ReturnCount")
override fun onMenuItemSelected(menuItem: MenuItem): Boolean { override fun onMenuItemSelected(menuItem: MenuItem): Boolean {
when (menuItem.itemId) { when (menuItem.itemId) {
android.R.id.home -> { android.R.id.home -> {