mirror of
https://github.com/kiwix/kiwix-android.git
synced 2025-08-03 10:46:53 -04:00
Detecting deprecated code via detekt and fixed detekt detection for the issues in project, and refactored deprecated rules of detekt
This commit is contained in:
parent
73fe388514
commit
af23cf56b7
2
.github/workflows/pull_request.yml
vendored
2
.github/workflows/pull_request.yml
vendored
@ -72,7 +72,7 @@ jobs:
|
||||
${{ runner.os }}-gradle-
|
||||
|
||||
- name: Static Analysis
|
||||
run: ./gradlew detekt
|
||||
run: ./gradlew detektDebug detektCustomExampleDebug
|
||||
- name: Upload Lint Reports
|
||||
uses: actions/upload-artifact@v3
|
||||
if: ${{ always() }}
|
||||
|
@ -22,6 +22,8 @@ import Config
|
||||
import Libs
|
||||
import com.android.build.api.dsl.CommonExtension
|
||||
import com.android.build.gradle.BaseExtension
|
||||
import io.gitlab.arturbosch.detekt.Detekt
|
||||
import io.gitlab.arturbosch.detekt.DetektCreateBaselineTask
|
||||
import io.gitlab.arturbosch.detekt.extensions.DetektExtension
|
||||
import org.gradle.api.Project
|
||||
import org.gradle.kotlin.dsl.apply
|
||||
@ -67,6 +69,12 @@ class AllProjectConfigurer {
|
||||
target.tasks.withType(KotlinCompile::class.java) {
|
||||
kotlinOptions.jvmTarget = "1.8"
|
||||
}
|
||||
target.tasks.withType(Detekt::class.java).configureEach {
|
||||
jvmTarget = "1.8"
|
||||
}
|
||||
target.tasks.withType(DetektCreateBaselineTask::class.java).configureEach {
|
||||
jvmTarget = "1.8"
|
||||
}
|
||||
buildFeatures.viewBinding = true
|
||||
|
||||
testOptions {
|
||||
|
@ -79,7 +79,8 @@ complexity:
|
||||
threshold: 60
|
||||
LongParameterList:
|
||||
active: true
|
||||
threshold: 6
|
||||
functionThreshold: 6
|
||||
constructorThreshold: 6
|
||||
ignoreDefaultParameters: false
|
||||
MethodOverloading:
|
||||
active: false
|
||||
@ -316,7 +317,7 @@ potential-bugs:
|
||||
LateinitUsage:
|
||||
active: false
|
||||
excludes: "**/test/**,**/androidTest/**,**/*.Test.kt,**/*.Spec.kt,**/*.Spek.kt"
|
||||
excludeAnnotatedProperties: ""
|
||||
ignoreAnnotated: []
|
||||
ignoreOnClassesPattern: ""
|
||||
MapGetWithNotNullAssertionOperator:
|
||||
active: false
|
||||
@ -379,7 +380,7 @@ style:
|
||||
active: true
|
||||
ignoreOverridableFunction: true
|
||||
excludedFunctions: 'describeContents'
|
||||
excludeAnnotatedFunction: "dagger.Provides"
|
||||
ignoreAnnotated: ["dagger.Provides"]
|
||||
LibraryCodeMustSpecifyReturnType:
|
||||
active: true
|
||||
LoopWithTooManyJumpStatements:
|
||||
@ -450,10 +451,10 @@ style:
|
||||
active: false
|
||||
UnderscoresInNumericLiterals:
|
||||
active: false
|
||||
acceptableDecimalLength: 5
|
||||
acceptableLength: 5
|
||||
UnnecessaryAbstractClass:
|
||||
active: true
|
||||
excludeAnnotatedClasses: "dagger.Module"
|
||||
ignoreAnnotated: ["dagger.Module"]
|
||||
UnnecessaryAnnotationUseSiteTarget:
|
||||
active: false
|
||||
UnnecessaryApply:
|
||||
@ -479,7 +480,7 @@ style:
|
||||
active: false
|
||||
UseDataClass:
|
||||
active: false
|
||||
excludeAnnotatedClasses: ""
|
||||
ignoreAnnotated: []
|
||||
allowVars: false
|
||||
UseIfInsteadOfWhen:
|
||||
active: false
|
||||
|
@ -2,7 +2,7 @@
|
||||
|
||||
echo "Running lint..."
|
||||
|
||||
./gradlew ktlintCheck detekt app:lintDebug custom:lintCustomexampleDebug --daemon
|
||||
./gradlew ktlintCheck detektDebug detektCustomExampleDebug app:lintDebug custom:lintCustomexampleDebug --daemon
|
||||
|
||||
status=$?
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user