kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-11 08:27:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Resolve lint errors and reduce inspection severity to info

Browse Source
This commit is contained in:
Sean Mac Gillicuddy 2019-09-03 12:13:30 +01:00
parent e7c3d5dcdf
commit b08b36a757
4 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.idea/inspectionProfiles/kiwixAndroidInspections.xml generated
View File

@ -343,7 +343,7 @@
<inspection_tool class="RemoveForLoopIndices" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="RemoveForLoopIndices" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="RemoveRedundantBackticks" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="RemoveRedundantBackticks" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="RemoveRedundantCallsOfConversionMethods" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="RemoveRedundantCallsOfConversionMethods" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="RemoveRedundantQualifierName" enabled="true" level="WEAK WARNING" enabled_by_default="true" /> <inspection_tool class="RemoveRedundantQualifierName" enabled="true" level="INFORMATION" enabled_by_default="true" />
<inspection_tool class="RemoveRedundantSpreadOperator" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="RemoveRedundantSpreadOperator" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="RemoveSetterParameterType" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="RemoveSetterParameterType" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="RemoveSingleExpressionStringTemplate" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="RemoveSingleExpressionStringTemplate" enabled="true" level="ERROR" enabled_by_default="true" />

1
app/src/main/java/org/kiwix/kiwixmobile/di/modules/ServiceModule.kt
View File

@ -67,4 +67,3 @@ class ServiceModule {
): HotspotNotificationManager = ): HotspotNotificationManager =
HotspotNotificationManager(notificationManager, context) HotspotNotificationManager(notificationManager, context)
} }

17
app/src/main/java/org/kiwix/kiwixmobile/utils/KiwixDialog.kt
View File

@ -2,7 +2,6 @@ package org.kiwix.kiwixmobile.utils
import android.net.wifi.WifiConfiguration import android.net.wifi.WifiConfiguration
import org.kiwix.kiwixmobile.R import org.kiwix.kiwixmobile.R
import org.kiwix.kiwixmobile.R.string
import org.kiwix.kiwixmobile.zim_manager.fileselect_view.adapter.BooksOnDiskListItem.BookOnDisk import org.kiwix.kiwixmobile.zim_manager.fileselect_view.adapter.BooksOnDiskListItem.BookOnDisk
sealed class KiwixDialog( sealed class KiwixDialog(
@ -39,7 +38,10 @@ sealed class KiwixDialog(
) )
object StoragePermissionRationale : KiwixDialog( object StoragePermissionRationale : KiwixDialog(
null, R.string.request_storage, android.R.string.yes, android.R.string.cancel null,
R.string.request_storage,
android.R.string.yes,
android.R.string.cancel
) )
object EnableWifiP2pServices : KiwixDialog( object EnableWifiP2pServices : KiwixDialog(
@ -71,11 +73,12 @@ sealed class KiwixDialog(
) )
} }
data class StartHotspotManually(val neutralMessage: Int = string.hotspot_dialog_neutral_button) : data class StartHotspotManually(
KiwixDialog( val neutralMessage: Int = R.string.hotspot_dialog_neutral_button
string.hotspot_dialog_title, ) : KiwixDialog(
string.hotspot_dialog_message, R.string.hotspot_dialog_title,
string.go_to_settings_label, R.string.hotspot_dialog_message,
R.string.go_to_settings_label,
null null
) )