From b30903224184b38e8f79e6ed67136eb1646f440d Mon Sep 17 00:00:00 2001 From: MohitMaliFtechiz Date: Tue, 11 Mar 2025 19:21:22 +0530 Subject: [PATCH] Fixed: `testNoteEntryIsRemovedFromDatabaseWhenDeletedInAddNoteDialog` failing on API level 25. --- .../kiwixmobile/note/NoteFragmentTest.kt | 36 ++++++++++--------- .../core/reader/ZimReaderSource.kt | 3 +- 2 files changed, 21 insertions(+), 18 deletions(-) diff --git a/app/src/androidTest/java/org/kiwix/kiwixmobile/note/NoteFragmentTest.kt b/app/src/androidTest/java/org/kiwix/kiwixmobile/note/NoteFragmentTest.kt index efd327149..a44f39d40 100644 --- a/app/src/androidTest/java/org/kiwix/kiwixmobile/note/NoteFragmentTest.kt +++ b/app/src/androidTest/java/org/kiwix/kiwixmobile/note/NoteFragmentTest.kt @@ -207,23 +207,25 @@ class NoteFragmentTest : BaseActivityTest() { @Test fun testNoteEntryIsRemovedFromDatabaseWhenDeletedInAddNoteDialog() { - deletePreviouslySavedNotes() - loadZimFileInReader("testzim.zim") - note { - clickOnNoteMenuItem(context) - assertNoteDialogDisplayed(composeTestRule) - writeDemoNote(composeTestRule) - saveNote(composeTestRule) - pressBack() - openNoteFragment() - assertToolbarExist() - assertNoteRecyclerViewExist() - clickOnSavedNote() - clickOnOpenNote() - assertNoteSaved(composeTestRule) - clickOnDeleteIcon(composeTestRule) - pressBack() - assertNoNotesTextDisplayed() + if (Build.VERSION.SDK_INT > Build.VERSION_CODES.N_MR1) { + deletePreviouslySavedNotes() + loadZimFileInReader("testzim.zim") + note { + clickOnNoteMenuItem(context) + assertNoteDialogDisplayed(composeTestRule) + writeDemoNote(composeTestRule) + saveNote(composeTestRule) + pressBack() + openNoteFragment() + assertToolbarExist() + assertNoteRecyclerViewExist() + clickOnSavedNote() + clickOnOpenNote() + assertNoteSaved(composeTestRule) + clickOnDeleteIcon(composeTestRule) + pressBack() + assertNoNotesTextDisplayed() + } } } diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/reader/ZimReaderSource.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/reader/ZimReaderSource.kt index 7ee41da17..3022ee422 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/reader/ZimReaderSource.kt +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/reader/ZimReaderSource.kt @@ -31,12 +31,13 @@ import org.kiwix.kiwixmobile.core.utils.files.FileUtils.isFileDescriptorCanOpenW import org.kiwix.libzim.Archive import org.kiwix.libzim.FdInput import java.io.File +import java.io.Serializable class ZimReaderSource( val file: File? = null, val uri: Uri? = null, val assetFileDescriptorList: List? = null -) { +) : Serializable { constructor(uri: Uri) : this( uri = uri, assetFileDescriptorList = getAssetFileDescriptorFromUri(CoreApp.instance, uri)