kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-29 08:00:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Open file with AssetFileDescriptor instead of File since we have restriction to directly access the files via filePath so instead of a file now we are acquiring the fileDescriptor approach since we can directly open ZIM files via file descriptor without any special permission. Therefore, we are now starting to utilize the fileDescriptor instead of a file.

Browse Source
This commit is contained in:
MohitMaliFtechiz 2023-12-27 15:20:12 +05:30
parent 5d97055a6a
commit b3b6c06a0e
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/src/main/java/org/kiwix/kiwixmobile/nav/destination/reader/KiwixReaderFragment.kt
View File

@ -19,7 +19,6 @@
package org.kiwix.kiwixmobile.nav.destination.reader package org.kiwix.kiwixmobile.nav.destination.reader
import android.content.Intent import android.content.Intent
import android.net.Uri
import android.os.Bundle import android.os.Bundle
import android.os.Handler import android.os.Handler
import android.os.Looper import android.os.Looper
@ -33,6 +32,7 @@ import android.view.View.VISIBLE
import android.view.ViewGroup import android.view.ViewGroup
import androidx.appcompat.app.AppCompatActivity import androidx.appcompat.app.AppCompatActivity
import androidx.core.net.toFile import androidx.core.net.toFile
import androidx.core.net.toUri
import androidx.drawerlayout.widget.DrawerLayout import androidx.drawerlayout.widget.DrawerLayout
import com.google.android.material.bottomnavigation.BottomNavigationView import com.google.android.material.bottomnavigation.BottomNavigationView
import org.kiwix.kiwixmobile.R import org.kiwix.kiwixmobile.R
@ -55,7 +55,6 @@ import org.kiwix.kiwixmobile.core.main.ToolbarScrollingKiwixWebView
import org.kiwix.kiwixmobile.core.utils.SharedPreferenceUtil import org.kiwix.kiwixmobile.core.utils.SharedPreferenceUtil
import org.kiwix.kiwixmobile.core.utils.TAG_CURRENT_FILE import org.kiwix.kiwixmobile.core.utils.TAG_CURRENT_FILE
import org.kiwix.kiwixmobile.core.utils.TAG_KIWIX import org.kiwix.kiwixmobile.core.utils.TAG_KIWIX
import org.kiwix.kiwixmobile.core.utils.files.FileUtils
import org.kiwix.kiwixmobile.core.utils.files.FileUtils.getAssetFileDescriptorFromUri import org.kiwix.kiwixmobile.core.utils.files.FileUtils.getAssetFileDescriptorFromUri
import java.io.File import java.io.File
@ -108,15 +107,18 @@ class KiwixReaderFragment : CoreReaderFragment() {
} }
private fun tryOpeningZimFile(zimFileUri: String) { private fun tryOpeningZimFile(zimFileUri: String) {
val filePath = FileUtils.getLocalFilePathByUri( getAssetFileDescriptorFromUri(
requireActivity().applicationContext, Uri.parse(zimFileUri) requireActivity(),
zimFileUri.toUri()
)?.let { assetFileDescriptor ->
openZimFile(
null,
assetFileDescriptor = assetFileDescriptor,
assetFileDescriptorPath = zimFileUri
) )
} ?: kotlin.run {
if (filePath == null || !File(filePath).isFileExist()) { activity.toast(R.string.cannot_open_file)
activity.toast(R.string.error_file_not_found)
return
} }
openZimFile(File(filePath))
} }
override fun loadDrawerViews() { override fun loadDrawerViews() {