kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-08-04 03:06:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed note saving with FileDescriptor.

Browse Source 
* Now we are using fileDescriptor for custom apps to read zim file from asset folder, so we have improved our notes saving functionality according to this change.
This commit is contained in:
MohitMali 2023-11-01 15:36:14 +05:30 committed by Kelson
parent f31535966b
commit b6d718f287
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/main/java/org/kiwix/kiwixmobile/core/main/AddNoteDialog.kt
View File

@ -117,7 +117,7 @@ class AddNoteDialog : DialogFragment() {
.inject(this) .inject(this)
// Returns name of the form ".../Kiwix/granbluefantasy_en_all_all_nopic_2018-10.zim" // Returns name of the form ".../Kiwix/granbluefantasy_en_all_all_nopic_2018-10.zim"
zimFileName = zimReaderContainer.zimCanonicalPath zimFileName = zimReaderContainer.zimCanonicalPath ?: zimReaderContainer.name
if (zimFileName != null) { // No zim file currently opened if (zimFileName != null) { // No zim file currently opened
zimFileTitle = zimReaderContainer.zimFileTitle zimFileTitle = zimReaderContainer.zimFileTitle
zimId = zimReaderContainer.id.orEmpty() zimId = zimReaderContainer.id.orEmpty()

9
core/src/main/java/org/kiwix/kiwixmobile/core/page/notes/viewmodel/effects/ShowOpenNoteDialog.kt
View File

@ -45,8 +45,13 @@ data class ShowOpenNoteDialog(
{ effects.offer(OpenPage(page, zimReaderContainer)) }, { effects.offer(OpenPage(page, zimReaderContainer)) },
{ {
val item = page as NoteListItem val item = page as NoteListItem
val file = File(item.zimFilePath.orEmpty()) // Check if zimFilePath is not null, and then set it in zimReaderContainer.
zimReaderContainer.setZimFile(file) // For custom apps, we are currently using fileDescriptor, and they only have a single file in them,
// which is already set in zimReaderContainer, so there's no need to set it again.
item.zimFilePath?.let {
val file = File(it)
zimReaderContainer.setZimFile(file)
}
effects.offer(OpenNote(item.noteFilePath, item.zimUrl, item.title)) effects.offer(OpenNote(item.noteFilePath, item.zimUrl, item.title))
} }
) )