kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-08-03 18:56:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Bug fix for #320 triggered when the library contained 1 item.

Browse Source 
A sample library_zim.xml is available at
https://github.com/kiwix/testfiles/blob/master/libraryfiles/one_item_in_library/library_zim.xml

The bug seems to have been introduced inadvertently in
b9930252e1
which returned a null to `getView(...)`

I've left a key log statement as this was one clue (after checking
various other areas of the codebase) that indicated there might be a
problem related to the number of entries rather than the attributes of
the item. I aim to revise the format of the log message as part of a
wider update on logging.
This commit is contained in:
Julian Harty 2017-12-14 20:32:21 +00:00 committed by Isaac Hutt
parent 7be9f61b83
commit c10d836370
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/org/kiwix/kiwixmobile/library/LibraryAdapter.java
View File

@ -24,6 +24,7 @@ import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
import android.os.AsyncTask;
import android.util.Base64;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
@ -118,7 +119,7 @@ public class LibraryAdapter extends BaseAdapter {
@Override
public View getView(int position, View convertView, ViewGroup parent) {
ViewHolder holder;
if (position + 1 >= listItems.size()) {
if (position >= listItems.size()) {
return convertView;
}
ListItem item = listItems.get(position);

2
app/src/main/java/org/kiwix/kiwixmobile/zim_manager/library_view/LibraryFragment.java
View File

@ -20,6 +20,7 @@ import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentManager;
import android.support.v4.widget.SwipeRefreshLayout;
import android.support.v7.app.AlertDialog;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
@ -156,6 +157,7 @@ public class LibraryFragment extends Fragment
@Override
public void showBooks(LinkedList<Book> books) {
Log.i("kiwix-showBooks", "Contains:" + books.size());
libraryAdapter.setAllBooks(books);
if (faActivity.searchView != null) {
libraryAdapter.getFilter().filter(