From c9ccfe7cca8c298f25095d8f663e1dfad255b531 Mon Sep 17 00:00:00 2001 From: MohitMali Date: Thu, 18 Aug 2022 19:23:12 +0530 Subject: [PATCH] Remove Play Core Services --- buildSrc/src/main/kotlin/Libs.kt | 6 ------ buildSrc/src/main/kotlin/Versions.kt | 2 -- .../src/main/kotlin/plugin/AllProjectConfigurer.kt | 1 - .../main/java/org/kiwix/kiwixmobile/core/CoreApp.kt | 11 ----------- core/src/main/res/values-fr/strings.xml | 1 - core/src/main/res/values-mk/strings.xml | 1 - core/src/main/res/values-sk/strings.xml | 1 - core/src/main/res/values/strings.xml | 1 - 8 files changed, 24 deletions(-) diff --git a/buildSrc/src/main/kotlin/Libs.kt b/buildSrc/src/main/kotlin/Libs.kt index bf4f3367c..5d63fbab0 100644 --- a/buildSrc/src/main/kotlin/Libs.kt +++ b/buildSrc/src/main/kotlin/Libs.kt @@ -420,10 +420,4 @@ object Libs { * https://developer.android.com/testing */ const val junit: String = "androidx.test.ext:junit:" + Versions.junit - - /** - * https://developer.android.com/reference/com/google/android/play/core/release-notes - */ - const val google_android_play_core: String = - "com.google.android.play:core:" + Versions.google_android_play_core } diff --git a/buildSrc/src/main/kotlin/Versions.kt b/buildSrc/src/main/kotlin/Versions.kt index 6f33af13f..8303b2026 100644 --- a/buildSrc/src/main/kotlin/Versions.kt +++ b/buildSrc/src/main/kotlin/Versions.kt @@ -12,8 +12,6 @@ import org.gradle.plugin.use.PluginDependencySpec */ object Versions { - const val google_android_play_core: String = "1.7.3" - const val document_file_version: String = "1.0.1" const val org_jetbrains_kotlinx_kotlinx_coroutines: String = "1.4.1" diff --git a/buildSrc/src/main/kotlin/plugin/AllProjectConfigurer.kt b/buildSrc/src/main/kotlin/plugin/AllProjectConfigurer.kt index 8fdd9ec9f..08bf42fd2 100644 --- a/buildSrc/src/main/kotlin/plugin/AllProjectConfigurer.kt +++ b/buildSrc/src/main/kotlin/plugin/AllProjectConfigurer.kt @@ -204,7 +204,6 @@ class AllProjectConfigurer { implementation(Libs.rxandroid) implementation(Libs.rxjava) implementation(Libs.preference_ktx) - implementation(Libs.google_android_play_core) } } } diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/CoreApp.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/CoreApp.kt index b00f44cf2..c99a56df0 100644 --- a/core/src/main/java/org/kiwix/kiwixmobile/core/CoreApp.kt +++ b/core/src/main/java/org/kiwix/kiwixmobile/core/CoreApp.kt @@ -17,7 +17,6 @@ */ package org.kiwix.kiwixmobile.core -import android.app.AlertDialog import android.app.Application import android.content.Context import android.os.Build @@ -26,7 +25,6 @@ import android.os.Environment.getExternalStorageState import android.os.StrictMode import android.os.StrictMode.VmPolicy import androidx.multidex.MultiDex -import com.google.android.play.core.missingsplits.MissingSplitsManagerFactory import com.jakewharton.threetenabp.AndroidThreeTen import org.kiwix.kiwixmobile.core.data.local.KiwixDatabase import org.kiwix.kiwixmobile.core.di.components.CoreComponent @@ -78,15 +76,6 @@ abstract class CoreApp : Application() { } override fun onCreate() { - if (MissingSplitsManagerFactory.create(this).disableAppIfMissingRequiredSplits()) { - AlertDialog.Builder(this) - .setMessage(R.string.missing_split_version_for_objectbox) - .setPositiveButton(R.string.yes) { _, _ -> - android.os.Process.killProcess(android.os.Process.myPid()) - } - .show() - return - } super.onCreate() instance = this coreComponent = DaggerCoreComponent.builder() diff --git a/core/src/main/res/values-fr/strings.xml b/core/src/main/res/values-fr/strings.xml index c967688b2..19f07556a 100644 --- a/core/src/main/res/values-fr/strings.xml +++ b/core/src/main/res/values-fr/strings.xml @@ -315,5 +315,4 @@ Ouvrir l’article Remarque : les notes ne sont pas supprimées de votre espace de stockage Supprimer les notes sélectionnées ? - Architecture non prise en charge, votre appareil n’est pas compatible avec cette application. diff --git a/core/src/main/res/values-mk/strings.xml b/core/src/main/res/values-mk/strings.xml index e018a1dbb..13813a75f 100644 --- a/core/src/main/res/values-mk/strings.xml +++ b/core/src/main/res/values-mk/strings.xml @@ -299,5 +299,4 @@ Отвори статија Напомена: Белешките не се избришани од вашиот склад Да ги избришам избраните белешки? - Неподдржана архитектура. Вашито уред не е складен со прилогов diff --git a/core/src/main/res/values-sk/strings.xml b/core/src/main/res/values-sk/strings.xml index 5ab62f73c..9bb51e8f3 100644 --- a/core/src/main/res/values-sk/strings.xml +++ b/core/src/main/res/values-sk/strings.xml @@ -302,5 +302,4 @@ Otvoriť článok Poznámka: Poznámky z vášho úložiska nie sú vymazané Odstrániť vybraté poznámky? - Nepodporovaná architektúra, vaše zariadenie nie je kompatibilné s touto aplikáciou diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml index ec3e14f4f..8f3a3bbad 100644 --- a/core/src/main/res/values/strings.xml +++ b/core/src/main/res/values/strings.xml @@ -323,5 +323,4 @@ Open Article Note: Notes are not deleted from your storage Delete Selected Notes? - Un-Supported architecture, your device isn\'t compatible with this app