kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-09-20 10:23:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

Resolved the application crash occurring when clicking the 'OPEN_NOTE' button in the NotesFragment.

Browse Source 
* Now, we primarily utilize the `FileDescriptor` instead of the file in conjunction with the URI for various functionalities. Consequently, we have refactored our note-opening functionality accordingly.
This commit is contained in:
MohitMaliFtechiz 2023-12-27 17:30:44 +05:30
parent 1f8c4e8ad0
commit d2505b7ca3
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
core/src/main/java/org/kiwix/kiwixmobile/core/page/notes/viewmodel/effects/ShowOpenNoteDialog.kt
View File

@ -19,6 +19,7 @@
package org.kiwix.kiwixmobile.core.page.notes.viewmodel.effects
import androidx.appcompat.app.AppCompatActivity
import androidx.core.net.toUri
import io.reactivex.processors.PublishProcessor
import org.kiwix.kiwixmobile.core.base.SideEffect
import org.kiwix.kiwixmobile.core.extensions.ActivityExtensions.cachedComponent
@ -29,7 +30,7 @@ import org.kiwix.kiwixmobile.core.page.viewmodel.effects.OpenPage
import org.kiwix.kiwixmobile.core.reader.ZimReaderContainer
import org.kiwix.kiwixmobile.core.utils.dialog.DialogShower
import org.kiwix.kiwixmobile.core.utils.dialog.KiwixDialog.ShowNoteDialog
import java.io.File
import org.kiwix.kiwixmobile.core.utils.files.FileUtils.getAssetFileDescriptorFromUri
import javax.inject.Inject
data class ShowOpenNoteDialog(
@ -49,8 +50,19 @@ data class ShowOpenNoteDialog(
// For custom apps, we are currently using fileDescriptor, and they only have a single file in them,
// which is already set in zimReaderContainer, so there's no need to set it again.
item.zimFilePath?.let {
val file = File(it)
zimReaderContainer.setZimFileOrFileDescriptor(file)
// Obtain the asset file descriptor for the provided URI.
// Given that we now exclusively use the fileDescriptor for all our functionalities,
// we have modified this method to assign the fileDescriptor instead of the file
// to address the crash triggered when clicking the 'OPEN NOTE' button.
getAssetFileDescriptorFromUri(
activity,
it.toUri()
)?.let { assetFileDescriptor ->
zimReaderContainer.setZimFileOrFileDescriptor(
assetFileDescriptor = assetFileDescriptor,
filePath = it
)
}
}
effects.offer(OpenNote(item.noteFilePath, item.zimUrl, item.title))
}