Merge pull request #4094 from kiwix/Fixes#4093

Improved the Note label in the OverFlowMenu for more clarity
This commit is contained in:
Kelson 2024-11-20 11:20:42 +01:00 committed by GitHub
commit d7a0628eaa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 2 deletions

View File

@ -67,7 +67,7 @@ class NoteRobot : BaseRobot() {
// overFlowOptionMenu so that we can easily click on it.
pauseForBetterTestPerformance()
openActionBarOverflowOrOptionsMenu(context)
clickOn(Text("Note"))
clickOn(TextId(R.string.take_notes))
}
fun assertNoteDialogDisplayed() {

View File

@ -20,7 +20,7 @@
<item
android:id="@+id/menu_add_note"
android:icon="@drawable/ic_add_note"
android:title="@string/note"
android:title="@string/take_notes"
android:visible="false"
app:showAsAction="never" />

View File

@ -233,6 +233,7 @@
<string name="custom_download_error_message_for_authentication_failed">The ZIM file could not be downloaded. Please try reinstalling the application from the Play store.</string>
<string name="save">Save</string>
<string name="note">Note</string>
<string name="take_notes">Take notes</string>
<string name="wiki_article_title">Wiki Article Title</string>
<string name="ext_storage_permission_rationale_export_bookmark">Storage access is required for exporting Bookmarks</string>
<string name="ext_storage_write_permission_denied_export_bookmark">Bookmarks cant export without access of storage</string>