kiwix/kiwix-android
1
0
Fork 0
mirror of https://github.com/kiwix/kiwix-android.git synced 2025-08-03 18:56:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Optimizing refresh. Issue #538 @GeVic comment.."

Browse Source 
This reverts commit cec66926e64d886ccc81622500b95d70b7fb9440.
As it causes a crash on certain devices due to android.os.TransactionTooLargeException
This commit is contained in:
mhutti1 2019-02-19 23:30:28 +00:00 committed by Isaac Hutt
parent 060b1a6db7
commit dc0e04adde
1 changed files with 3 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
app/src/main/java/org/kiwix/kiwixmobile/zim_manager/library_view/LibraryFragment.java
View File

@ -40,7 +40,6 @@ import android.widget.ListView;
import android.widget.TextView; import android.widget.TextView;
import android.widget.Toast; import android.widget.Toast;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentManager;
import androidx.swiperefreshlayout.widget.SwipeRefreshLayout; import androidx.swiperefreshlayout.widget.SwipeRefreshLayout;
import androidx.test.espresso.idling.CountingIdlingResource; import androidx.test.espresso.idling.CountingIdlingResource;
@ -81,8 +80,8 @@ public class LibraryFragment extends BaseFragment
public static final CountingIdlingResource IDLING_RESOURCE = public static final CountingIdlingResource IDLING_RESOURCE =
new CountingIdlingResource("Library Fragment Idling Resource"); new CountingIdlingResource("Library Fragment Idling Resource");
public static final List<Book> downloadingBooks = new ArrayList<>(); public static final List<Book> downloadingBooks = new ArrayList<>();
private static final String EXTRA_BOOKS_ONLINE = "books_online";
public static DownloadService downloadService = new DownloadService(); public static DownloadService downloadService = new DownloadService();
private static NetworkBroadcastReceiver networkBroadcastReceiver; private static NetworkBroadcastReceiver networkBroadcastReceiver;
private static boolean isReceiverRegistered = false; private static boolean isReceiverRegistered = false;
public LibraryAdapter libraryAdapter; public LibraryAdapter libraryAdapter;
@ -100,9 +99,9 @@ public class LibraryFragment extends BaseFragment
LibraryPresenter presenter; LibraryPresenter presenter;
@Inject @Inject
SharedPreferenceUtil sharedPreferenceUtil; SharedPreferenceUtil sharedPreferenceUtil;
private LinkedList<Book> books;
private boolean bound; private boolean bound;
private DownloadServiceConnection downloadServiceConnection = new DownloadServiceConnection(); private DownloadServiceConnection downloadServiceConnection = new DownloadServiceConnection();
private ZimManageActivity activity; private ZimManageActivity activity;
@Override @Override
@ -154,7 +153,7 @@ public class LibraryFragment extends BaseFragment
IDLING_RESOURCE.decrement(); IDLING_RESOURCE.decrement();
return; return;
} }
this.books = books;
Log.i("kiwix-showBooks", "Contains:" + books.size()); Log.i("kiwix-showBooks", "Contains:" + books.size());
libraryAdapter.setAllBooks(books); libraryAdapter.setAllBooks(books);
if (activity.searchView != null) { if (activity.searchView != null) {
@ -335,22 +334,6 @@ public class LibraryFragment extends BaseFragment
} }
} }
@Override
public void onSaveInstanceState(@NonNull Bundle outState) {
super.onSaveInstanceState(outState);
outState.putSerializable(EXTRA_BOOKS_ONLINE, books);
}
@Override
public void onViewStateRestored(@Nullable Bundle savedInstanceState) {
super.onViewStateRestored(savedInstanceState);
if ((savedInstanceState != null && savedInstanceState.containsKey(EXTRA_BOOKS_ONLINE))) {
//noinspection unchecked
books = (LinkedList<Book>) savedInstanceState.getSerializable(EXTRA_BOOKS_ONLINE);
showBooks(books);
}
}
class DownloadServiceConnection { class DownloadServiceConnection {
final DownloadServiceInterface downloadServiceInterface; final DownloadServiceInterface downloadServiceInterface;