Restricting testExtractDocumentId and testDocumentProviderContentQuery test cases on API level 33 since numerous security updates have been included, preventing us from modifying the default behavior of ContentResolver. So running the test case on this APi level leads to test failure.

2025-09-12 17:08:59 -04:00 · 2024-03-16 20:06:30 +05:30 · 2024-03-16 20:06:30 +05:30 · e1c69aa259
commit e1c69aa259
parent dbbd02b08b
1 changed files with 91 additions and 79 deletions
--- a/app/src/androidTest/java/org/kiwix/kiwixmobile/utils/files/FileUtilsInstrumentationTest.kt
+++ b/app/src/androidTest/java/org/kiwix/kiwixmobile/utils/files/FileUtilsInstrumentationTest.kt
@ -354,97 +354,109 @@ class FileUtilsInstrumentationTest {

  @Test
  fun testExtractDocumentId() {
-    val dummyDownloadUriData = arrayOf(
-      DummyUrlData(
-        null,
-        "raw:$expectedFilePath",
-        Uri.parse("${downloadDocumentUriPrefix}raw%3A%2Fstorage%2Femulated%2F0%2F$commonUri")
-      ),
-      DummyUrlData(
-        null,
-        expectedFilePath,
-        Uri.parse("$downloadDocumentUriPrefix%2Fstorage%2Femulated%2F0%2F$commonUri")
-      ),
-      DummyUrlData(
-        null,
-        "",
-        Uri.parse(downloadUriPrefix)
-      )
-    )
-
-    dummyDownloadUriData.forEach { dummyUrlData ->
-      dummyUrlData.uri?.let { uri ->
-        Assertions.assertEquals(
-          FileUtils.extractDocumentId(uri, DocumentResolverWrapper()),
-          dummyUrlData.expectedFileName
+    // We are not running this test case on Android 13 and above. In this version,
+    // numerous security updates have been included, preventing us from modifying the
+    // default behavior of ContentResolver.
+    // Therefore, we are restricting this test to API level 33 and below.
+    if (Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU) {
+      val dummyDownloadUriData = arrayOf(
+        DummyUrlData(
+          null,
+          "raw:$expectedFilePath",
+          Uri.parse("${downloadDocumentUriPrefix}raw%3A%2Fstorage%2Femulated%2F0%2F$commonUri")
+        ),
+        DummyUrlData(
+          null,
+          expectedFilePath,
+          Uri.parse("$downloadDocumentUriPrefix%2Fstorage%2Femulated%2F0%2F$commonUri")
+        ),
+        DummyUrlData(
+          null,
+          "",
+          Uri.parse(downloadUriPrefix)
        )
-      }
-    }
+      )

-    // Testing with a dynamically generated URI. This URI creates at runtime,
-    // and passing it statically would result in an `IllegalArgumentException` exception.
-    // Therefore, we simulate this scenario using the `DocumentsContractWrapper`
-    // to conduct the test.
-    val mockDocumentsContractWrapper: DocumentResolverWrapper = mockk()
-    val expectedDocumentId = "1000020403"
-    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
-      // Below Android 10, download URI schemes are of the content type, such as:
-      // content://com.android.chrome.FileProvider/downloads/alpinelinux_en_all_nopic_2022-12.zim
-      // As a result, this method will not be called during that time. We are not testing it on
-      // Android versions below 10, as it would result in an "IllegalArgumentException" exception.
-      val mockedUri = Uri.parse("$downloadUriPrefix$expectedDocumentId")
-      every { mockDocumentsContractWrapper.getDocumentId(mockedUri) } returns expectedDocumentId
-      val actualDocumentId = FileUtils.extractDocumentId(mockedUri, mockDocumentsContractWrapper)
-      assertEquals(expectedDocumentId, actualDocumentId)
+      dummyDownloadUriData.forEach { dummyUrlData ->
+        dummyUrlData.uri?.let { uri ->
+          Assertions.assertEquals(
+            FileUtils.extractDocumentId(uri, DocumentResolverWrapper()),
+            dummyUrlData.expectedFileName
+          )
+        }
+      }
+
+      // Testing with a dynamically generated URI. This URI creates at runtime,
+      // and passing it statically would result in an `IllegalArgumentException` exception.
+      // Therefore, we simulate this scenario using the `DocumentsContractWrapper`
+      // to conduct the test.
+      val mockDocumentsContractWrapper: DocumentResolverWrapper = mockk()
+      val expectedDocumentId = "1000020403"
+      if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+        // Below Android 10, download URI schemes are of the content type, such as:
+        // content://com.android.chrome.FileProvider/downloads/alpinelinux_en_all_nopic_2022-12.zim
+        // As a result, this method will not be called during that time. We are not testing it on
+        // Android versions below 10, as it would result in an "IllegalArgumentException" exception.
+        val mockedUri = Uri.parse("$downloadUriPrefix$expectedDocumentId")
+        every { mockDocumentsContractWrapper.getDocumentId(mockedUri) } returns expectedDocumentId
+        val actualDocumentId = FileUtils.extractDocumentId(mockedUri, mockDocumentsContractWrapper)
+        assertEquals(expectedDocumentId, actualDocumentId)
+      }
    }
  }

  @Test
  fun testDocumentProviderContentQuery() {
-    // test to get the download uri on old device
-    testWithDownloadUri(
-      Uri.parse("${downloadDocumentUriPrefix}raw%3A%2Fstorage%2Femulated%2F0%2F$commonUri"),
-      expectedFilePath
-    )
+    // We are not running this test case on Android 13 and above. In this version,
+    // numerous security updates have been included, preventing us from modifying the
+    // default behavior of ContentResolver.
+    // Therefore, we are restricting this test to API level 33 and below.
+    if (Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU) {
+      // test to get the download uri on old device
+      testWithDownloadUri(
+        Uri.parse("${downloadDocumentUriPrefix}raw%3A%2Fstorage%2Femulated%2F0%2F$commonUri"),
+        expectedFilePath
+      )

-    // test to get the download uri on new device
-    testWithDownloadUri(
-      Uri.parse("$downloadDocumentUriPrefix%2Fstorage%2Femulated%2F0%2F$commonUri"),
-      expectedFilePath
-    )
+      // test to get the download uri on new device
+      testWithDownloadUri(
+        Uri.parse("$downloadDocumentUriPrefix%2Fstorage%2Femulated%2F0%2F$commonUri"),
+        expectedFilePath
+      )

-    // test with all possible download uris
-    val contentUriPrefixes = arrayOf(
-      "content://downloads/public_downloads",
-      "content://downloads/my_downloads",
-      "content://downloads/all_downloads"
-    )
+      // test with all possible download uris
+      val contentUriPrefixes = arrayOf(
+        "content://downloads/public_downloads",
+        "content://downloads/my_downloads",
+        "content://downloads/all_downloads"
+      )

-    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
-      // Below Android 10, download URI schemes are of the content type, such as:
-      // content://com.android.chrome.FileProvider/downloads/alpinelinux_en_all_nopic_2022-12.zim
-      // As a result, this method will not be called during that time. We are not testing it on
-      // Android versions below 10, as it would result in an "IllegalArgumentException" exception.
-      contentUriPrefixes.forEach {
-        val mockDocumentsContractWrapper: DocumentResolverWrapper = mockk()
-        val expectedDocumentId = "1000020403"
-        val mockedUri = Uri.parse("$it/$expectedDocumentId")
-        every { mockDocumentsContractWrapper.getDocumentId(mockedUri) } returns expectedDocumentId
-        every {
-          mockDocumentsContractWrapper.query(
-            context!!,
+      if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+        // Below Android 10, download URI schemes are of the content type, such as:
+        // content://com.android.chrome.FileProvider/downloads/alpinelinux_en_all_nopic_2022-12.zim
+        // As a result, this method will not be called during that time. We are not testing it on
+        // Android versions below 10, as it would result in an "IllegalArgumentException" exception.
+        contentUriPrefixes.forEach {
+          val mockDocumentsContractWrapper: DocumentResolverWrapper = mockk()
+          val expectedDocumentId = "1000020403"
+          val mockedUri = Uri.parse("$it/$expectedDocumentId")
+          every { mockDocumentsContractWrapper.getDocumentId(mockedUri) } returns expectedDocumentId
+          every {
+            mockDocumentsContractWrapper.query(
+              context!!,
+              mockedUri,
+              "_data",
+              null,
+              null,
+              null
+            )
+          } returns expectedFilePath
+          testWithDownloadUri(
            mockedUri,
-            "_data",
-            null,
-            null,
-            null
+            expectedFilePath,
+            mockDocumentsContractWrapper
          )
-        } returns expectedFilePath
-        testWithDownloadUri(
-          mockedUri,
-          expectedFilePath,
-          mockDocumentsContractWrapper
-        )
+        }
      }
    }
  }